Code review comment for lp:~tj/ubuntu/trusty/alsa-utils/lp1269731

On 16/01/14 23:52, Luke Yelavich wrote:
> Thanks for your work, however ou don't patch files in the debian directory. You edit them directly.

Seems obviously now after a full nights sleep - when I identified the work-around I just wanted to tie it off and get some sleep and it looks like my brain had stopped working!
>
> Secondly, as per the bug, the original shell code is syntactically correct, and I forgot to add an env declaration to the ALSACTLHOME variable, whichi I already have a fix for, and am about to upload.
>
Right - we used a process of elimination and comparison to identify the syntax issue and the "if test..." construct wasn't being used in that form in any other init script.

Of course the prime cause is the lack of a guard around the pointer dereference in the upstart code, but that needs someone familiar with that code-base to deal with since there are other issues
around not failing-safe when it doesn't accept the syntax.