Merge lp:~tj/simple-scan/lp892915 into lp:~simple-scan-team/simple-scan/trunk

Proposed by TJ
Status: Merged
Merged at revision: 627
Proposed branch: lp:~tj/simple-scan/lp892915
Merge into: lp:~simple-scan-team/simple-scan/trunk
Diff against target: 68 lines (+17/-5)
1 file modified
src/scanner.vala (+17/-5)
To merge this branch: bzr merge lp:~tj/simple-scan/lp892915
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+175377@code.launchpad.net

Description of the change

Add support for the Samsung Unified Driver (SUD) which enables ADF Duplex and correct colour mode selection. Tested on Samsung CLX-6220FX with ADF Duplex. (Closes LP: #892915)

To post a comment you must log in.
Revision history for this message
Robert Ancell (robert-ancell) wrote :

Thanks TJ, nice work! Pushed with minor whitespace and logging changes.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/scanner.vala'
2--- src/scanner.vala 2013-03-21 20:09:02 +0000
3+++ src/scanner.vala 2013-07-17 19:03:35 +0000
4@@ -863,7 +863,12 @@
5 if (option == null)
6 {
7 /* Pick source */
8+ debug("Getting SCAN_SOURCE %s", Sane.NAME_SCAN_SOURCE);
9 option = get_option_by_name (handle, Sane.NAME_SCAN_SOURCE, out index);
10+ if (option == null) {
11+ debug("Trying alternative SCAN_SOURCE %s", "doc-source");
12+ option = get_option_by_name (handle, "doc-source", out index); /* Samsung unified driver. LP: #892915 */
13+ }
14 if (option != null)
15 {
16 string[] flatbed_sources =
17@@ -883,7 +888,8 @@
18 Sane.I18N ("Automatic Document Feeder"),
19 "ADF",
20 "Automatic Document Feeder(left aligned)", /* Seen in the proprietary brother3 driver */
21- "Automatic Document Feeder(centrally aligned)" /* Seen in the proprietary brother3 driver */
22+ "Automatic Document Feeder(centrally aligned)", /* Seen in the proprietary brother3 driver */
23+ "ADF Simplex" /* Samsung unified driver. LP: # 892915 */
24 };
25
26 string[] adf_front_sources =
27@@ -901,7 +907,9 @@
28 string[] adf_duplex_sources =
29 {
30 "ADF Duplex",
31- Sane.I18N ("ADF Duplex")
32+ Sane.I18N ("ADF Duplex"),
33+ "ADF Duplex - Long-Edge Binding", /* Samsung unified driver. LP: # 892915 */
34+ "ADF Duplex - Short-Edge Binding"
35 };
36
37 switch (job.type)
38@@ -938,7 +946,8 @@
39 {
40 Sane.VALUE_SCAN_MODE_COLOR,
41 "Color",
42- "24bit Color" /* Seen in the proprietary brother3 driver */
43+ "24bit Color", /* Seen in the proprietary brother3 driver */
44+ "Color - 16 Million Colors" /* Samsung unified driver. LP: 892915 */
45 };
46 string[] gray_scan_modes =
47 {
48@@ -946,7 +955,8 @@
49 "Gray",
50 "Grayscale",
51 Sane.I18N ("Grayscale"),
52- "True Gray" /* Seen in the proprietary brother3 driver */
53+ "True Gray", /* Seen in the proprietary brother3 driver */
54+ "Grayscale - 256 Levels" /* Samsung unified driver. LP: 892915 */
55 };
56 string[] lineart_scan_modes =
57 {
58@@ -963,7 +973,9 @@
59 "Gray",
60 "Grayscale",
61 Sane.I18N ("Grayscale"),
62- "True Gray" /* Seen in the proprietary brother3 driver */
63+ "True Gray", /* Seen in the proprietary brother3 driver */
64+ "Black and White - Line Art", /* Samsung unified driver. LP: 892915 */
65+ "Black and White - Halftone"
66 };
67
68 switch (job.scan_mode)

Subscribers

People subscribed via source and target branches