Linaro Image Tools

Merge lp:~tixy/linaro-image-tools/sdcard-partition-as-fat32 into lp:linaro-image-tools/11.11

  1. sdcard-partition-as-fat32
  2. Merge into trunk
Proposed by Tixy (Jon Medhurst)
Status: Merged
Merged at revision: 482
Proposed branch: lp:~tixy/linaro-image-tools/sdcard-partition-as-fat32
Merge into: lp:linaro-image-tools/11.11
Diff against target: 12 lines (+1/-1)
1 file modified
linaro_image_tools/media_create/partitions.py (+1/-1)
To merge this branch: bzr merge lp:~tixy/linaro-image-tools/sdcard-partition-as-fat32
Reviewer Review Type Date Requested Status
Loïc Minier (community) Approve
Review via email: mp+86594@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Loïc Minier (lool) wrote :

Patching the common code to hardcode FAT32 instead of changing fat_size for your board seems wrong, unless we're sure no hwpack uses FAT16

review: Needs Fixing
Revision history for this message
Loïc Minier (lool) wrote :

Sorry had misunderstood, you just changed the Android user data partition which can always be FAT32 as it's only used by linux or a remote OS (over USB); that's fine!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'linaro_image_tools/media_create/partitions.py'
2--- linaro_image_tools/media_create/partitions.py 2011-07-28 01:24:21 +0000
3+++ linaro_image_tools/media_create/partitions.py 2011-12-21 17:56:31 +0000
4@@ -93,7 +93,7 @@
5 proc.wait()
6
7 proc = cmd_runner.run(
8- ['mkfs.vfat', '-F', str(board_config.fat_size), sdcard, '-n',
9+ ['mkfs.vfat', '-F32', sdcard, '-n',
10 "sdcard"],
11 as_root=True)
12 proc.wait()

Subscribers

People subscribed via source and target branches