Merge lp:~titanous/goamz/s3test-fix-metadata into lp:~gophers/goamz/trunk

[Jonathan Rudenberg]

[Gustavo Niemeyer (niemeyer)]

Good catch, thanks.

Is there anything guaranteeing that this header is in Canonical form by then?

[Jonathan Rudenberg (titanous)]

I don't think so. It depends on how the req.Header was built, but I suspect that in most cases this will be correct. An alternative is to use strings.ToLower before comparing.

[Gustavo Niemeyer (niemeyer)]

Sounds good. I've merged this, but uses http.CanonicalHeaderKey before the comparison.

Thanks again.

=== modified file 's3/s3test/server.go'
--- s3/s3test/server.go	2012-12-10 23:38:27 +0000
+++ s3/s3test/server.go	2013-02-08 02:43:38 +0000
@@ -584,7 +584,7 @@
 
 	// PUT request has been successful - save data and metadata
 	for key, values := range a.req.Header {
-		if metaHeaders[key] || strings.HasPrefix(key, "x-amz-meta-") {
+		if metaHeaders[key] || strings.HasPrefix(key, "X-Amz-Meta-") {
 			obj.meta[key] = values
 		}
 	}