Code review comment for lp:~tintou/maya/3.10

Revision history for this message
Danielle Foré (danrabbit) wrote :

With the popover:

1. It seems the submenus must be the same width as the main menu in order to avoid a rendering error with the arrow
2. The "Add New Calendar" button should probably be full width to make it behave more like a menu item. And we may want to experiment with giving it the css class of ".menuitem"
3. The icons for edit and delete should be only 16px because right now they're being stretched out.
4. When deleting an item, the popover doesn't shrink vertically after the undo message is dismissed.
5. The Add New Calendar item only allows me to add a local calendar, not a google or caldav. The combobox for "type" seems to be missing.
6. If possible, I would like the separator item to be the full width of the popover like how separators are in menus

review: Needs Fixing

« Back to merge proposal