libreoffice-online:distro/collabora/co-4-2-5

Last commit made on 2020-07-17
Get this branch:
git clone -b distro/collabora/co-4-2-5 https://git.launchpad.net/libreoffice-online

Branch merges

Branch information

Name:
distro/collabora/co-4-2-5
Repository:
lp:libreoffice-online

Recent commits

edd1b83... by Jan Holesovsky <email address hidden>

android: Log when we disable editing for easier debugging.

Change-Id: I358b1a50be7f9f377e9376f8b1772ad92fd059ae
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98976
Tested-by: Jan Holesovsky <email address hidden>
Reviewed-by: Jan Holesovsky <email address hidden>

2c739a8... by Jan Holesovsky <email address hidden>

android: One more location that fails to save on Chrome OS.

Turns out that saving directly to "My files" is problematic in some
cases too; suggest to use the "Play files" location.

Change-Id: Ifb88fc048685596f85e7cf39a57c60864da12d83
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98943
Tested-by: Jan Holesovsky <email address hidden>
Reviewed-by: Jan Holesovsky <email address hidden>

1f798b2... by Aron Budea <email address hidden>

Bump package version to 4.2.5-6

Change-Id: I7a68393f17df1781ef66ffc39616064bf819d228

2881605... by Jan Holesovsky <email address hidden>

android: Hide sidebar on Chromebooks early.

This is a hack - but I fear the best we can do just now. The problem is
that the sidebar is always initialized at the startup, just for mobile
phones and tablets, we don't show it thanks to an early exit in
_launchSidebar() when the app starts in read-only mode (which it does
for phones and tablets).

Now when we have switched the Chromebook UI to the desktop one, we need
to explicitly turn the sidebar off on start, because otherwise it
occupies too much screen.

Of course - much better would be not to initialize the sidebar at all
when it is not necessary - but there's no easy way to do that :-(

Change-Id: I0340d125181285dcebda4ff78971182a7072dddb
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98862
Tested-by: Jan Holesovsky <email address hidden>
Reviewed-by: Jan Holesovsky <email address hidden>

8c416d9... by Jan Holesovsky <email address hidden>

android: Actually use the Desktop browser UI for Chromebooks.

Chromebooks are not touch devices, the desktop browser-like UI makes
much more sense there.

Change-Id: Id963929e781f2baff32a65e0437afb4dfd8460a3
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98861
Tested-by: Jan Holesovsky <email address hidden>
Reviewed-by: Jan Holesovsky <email address hidden>

a522118... by Jan Holesovsky <email address hidden>

android: Add support for ODT/ODS/ODP for Chrome OS.

Turns out that the ODF mime types are most probably not supported by
Chrome OS, because the android:mimeType=... is not enough to associate
the app with the ODT/ODP/ODS files.

So introduce an additional intent-filter that explicitly matches
according to the file extension; a bit hacky, but works.

Change-Id: If7cad42333314e8d16f96d035380460d5c3da347
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98784
Tested-by: Jan Holesovsky <email address hidden>
Reviewed-by: Jan Holesovsky <email address hidden>

c543ee2... by Jan Holesovsky <email address hidden>

android: Call the SAVE directly from the native code.

Until now, for the "local save has completed, upload it back to the
content: URI" messages we were relying on the "local save" -> JavaScript
-> Java -> "upload to content:/ URI" chain.

It turns out though, that the WebView can be dead by the time we need
the notification that the save has completed. This was particularly
seen on ChromeOS when the document was closed using the [x] in the
window decoration.

As a solution, we need to pass the info that the "local save" has
completed directly to Java. So far this uses the same semantics as the
postMobileMessage() and reuse its code; but maybe in the future we'll
need to split this.

Change-Id: If1b93e4f76cee3abc6aebfc3e9072810ab73bb42
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98724
Tested-by: Jan Holesovsky <email address hidden>
Reviewed-by: Michael Meeks <email address hidden>

fffcc45... by Jan Holesovsky <email address hidden>

android: A small follow-up, the intention was an early return.

Change-Id: I3a73cd03c9ec51b7f190092702b4ef860c1f589b
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98748
Tested-by: Jan Holesovsky <email address hidden>
Reviewed-by: Jan Holesovsky <email address hidden>

1f0a184... by Jan Holesovsky <email address hidden>

android: Avoid calling methods of a destroyed WebView.

Avoids exceptions like:

2020-07-13 13:19:49.607 2919-2919/? I/LOActivity: Forwarding to the WebView: 'statusindicatorsetvalue: 86'
2020-07-13 13:19:49.609 2919-2919/? W/cr_AwContents: Application attempted to call on a destroyed WebView
    java.lang.Throwable
        at org.chromium.android_webview.AwContents.t(chromium-SystemWebViewGoogle.apk-stable-410410651:2)
        at com.android.webview.chromium.WebViewChromium.loadUrl(chromium-SystemWebViewGoogle.apk-stable-410410651:11)
        at android.webkit.WebView.loadUrl(WebView.java:970)
        at org.libreoffice.androidlib.LOActivity$6.run(LOActivity.java:794)
        at android.os.Handler.handleCallback(Handler.java:873)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loop(Looper.java:193)
        at android.app.ActivityThread.main(ActivityThread.java:6971)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:865)

Change-Id: Ic853131bac937deec7e68723b956a4ab7cf61872
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/98723
Tested-by: Michael Meeks <email address hidden>
Reviewed-by: Michael Meeks <email address hidden>

3398cb6... by Pranam Lashkari <email address hidden>

leaflet: removed slide controls from draw

Change-Id: I5916d829b257729363125643cf3ba548f7e4e9db
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97759
Tested-by: Jenkins
Tested-by: Jenkins CollaboraOffice <email address hidden>
Reviewed-by: Andras Timar <email address hidden>
(cherry picked from commit 99944f8842e73a4207c230f895ac02ecba23cfd0)
Reviewed-on: https://gerrit.libreoffice.org/c/online/+/97798
Tested-by: Andras Timar <email address hidden>