Merge lp:~tintou/granite/deprecation into lp:~elementary-pantheon/granite/granite

Proposed by Corentin Noël
Status: Merged
Approved by: Cody Garver
Approved revision: 833
Merged at revision: 842
Proposed branch: lp:~tintou/granite/deprecation
Merge into: lp:~elementary-pantheon/granite/granite
Diff against target: 32 lines (+2/-2)
2 files modified
lib/Widgets/PopOver.vala (+1/-2)
lib/Widgets/WrapLabel.vala (+1/-0)
To merge this branch: bzr merge lp:~tintou/granite/deprecation
Reviewer Review Type Date Requested Status
Victor Martinez (community) Approve
Cody Garver (community) Needs Information
Robert Roth (community) Approve
Review via email: mp+249003@code.launchpad.net

Commit message

Adds the deprecation annotation to deprecate widgets officially.
[WrapLabel] No need for this widget when Gtk.Label provides wrapping label.
[PopOver] Replaced by Gtk.Popover.

Fixed some deprecations annotations as we deprecate widgets when they are available in Gtk.

Description of the change

Adds the deprecation annotation to deprecate widgets officially.
[WrapLabel] No need for this widget when Gtk.Label provides wrapping label.
[PopOver] Replaced by Gtk.Popover.

Fixed some deprecations annotations as we deprecate widgets when they are available in Gtk.

To post a comment you must log in.
Revision history for this message
Robert Roth (evfool) wrote :

Looks fine and sane, approving.

review: Approve
Revision history for this message
Cody Garver (codygarver) wrote :

I thought "since" is supposed to be the version of the [Granite] library it was deprecated in

review: Needs Information
Revision history for this message
Victor Martinez (victored) wrote :

Cody's right. The deprecated symbols belong to Granite and not GTK+. Deprecations can only be tracked against our own versions.

review: Needs Fixing
lp:~tintou/granite/deprecation updated
833. By Corentin Noël

Using Granite versions.

Revision history for this message
Corentin Noël (tintou) wrote :

Okay I changed the version to Granite's.
So let's deprecate Granite.Widgets.PopOver and Granite.Widgets.WrapLabel.

Revision history for this message
Victor Martinez (victored) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/Widgets/PopOver.vala'
2--- lib/Widgets/PopOver.vala 2014-09-04 12:39:00 +0000
3+++ lib/Widgets/PopOver.vala 2015-03-10 11:05:55 +0000
4@@ -18,8 +18,6 @@
5 */
6
7 /**
8- * /!\ Unstable API
9- *
10 * PopOver widget. It is a Dialog you can attach to a widget, e.g. a button.
11 *
12 * It is a dialog you can attach to a widget, to make it look
13@@ -33,6 +31,7 @@
14 * {{../../doc/images/PopOver.png}}
15 *
16 */
17+[Deprecated (replacement = "Gtk.Popover", since = "0.3")]
18 public class Granite.Widgets.PopOver : Gtk.Dialog
19 {
20 protected int BORDER_RADIUS;
21
22=== modified file 'lib/Widgets/WrapLabel.vala'
23--- lib/Widgets/WrapLabel.vala 2014-09-04 12:39:00 +0000
24+++ lib/Widgets/WrapLabel.vala 2015-03-10 11:05:55 +0000
25@@ -27,6 +27,7 @@
26 * This is a label which is automatically wrapped.
27 * If a line is too long, there will be a line break for instance.
28 */
29+[Deprecated (replacement = "Gtk.Label", since = "0.3")]
30 public class Granite.Widgets.WrapLabel : Label {
31
32 public int m_wrap_width = 0;

Subscribers

People subscribed via source and target branches