Merge lp:~timo-jyrinki/unity-webapps-qml/build_dep_on_oxide into lp:unity-webapps-qml

Proposed by Timo Jyrinki
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 112
Merged at revision: 111
Proposed branch: lp:~timo-jyrinki/unity-webapps-qml/build_dep_on_oxide
Merge into: lp:unity-webapps-qml
Diff against target: 12 lines (+2/-0)
1 file modified
debian/control (+2/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/unity-webapps-qml/build_dep_on_oxide
Reviewer Review Type Date Requested Status
David Barth (community) Approve
Didier Roche-Tolomelli Approve
Review via email: mp+214673@code.launchpad.net

Commit message

Depend on liboxideqtcore0 to limit archs to be built to the set for which webapps-qml is installable for.

Description of the change

Makes sense or not, there's no oxide '-dev' package?

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

mind adding a comment just on top of it on the "why"?

review: Needs Fixing
112. By Timo Jyrinki

Add comment to control

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks Timo!

review: Approve
Revision history for this message
David Barth (dbarth) wrote :

+1 and thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-04-03 14:17:12 +0000
3+++ debian/control 2014-04-08 07:20:52 +0000
4@@ -6,6 +6,8 @@
5 gdb,
6 libmessaging-menu-dev,
7 libnotify-dev,
8+# depend on oxide so that we don't build for archs that we can't install on
9+ liboxideqtcore0,
10 libqt5webkit5-dev,
11 libunity-action-qt1-dev,
12 libunity-dev,

Subscribers

People subscribed via source and target branches

to all changes: