Merge lp:~timo-jyrinki/unity-scope-click/switch_to_frameworks_dependency into lp:unity-scope-click

Proposed by Timo Jyrinki
Status: Rejected
Rejected by: Timo Jyrinki
Proposed branch: lp:~timo-jyrinki/unity-scope-click/switch_to_frameworks_dependency
Merge into: lp:unity-scope-click
Diff against target: 11 lines (+0/-1)
1 file modified
debian/control (+0/-1)
To merge this branch: bzr merge lp:~timo-jyrinki/unity-scope-click/switch_to_frameworks_dependency
Reviewer Review Type Date Requested Status
dobey (community) Needs Information
PS Jenkins bot continuous-integration Approve
Review via email:

Commit message

Drop the ubuntu-sdk-libs dependency (LP: #1399597)

To post a comment you must log in.
305. By Timo Jyrinki

Drop the dependency instead.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

The bug severity was lowered as the critical problem was resolved by moving the codec package. Still, in the discussions it was brought up that unity-scope-click should not have a runtime dependency on ubuntu-sdk-libs (which has a big list of dependencies), but instead query the available frameworks manually.

Revision history for this message
dobey (dobey) wrote :

Is there some other way to depend on the frameworks files actually being installed on the system, without a dep on ubuntu-sdk-libs? The dep was added because the frameworks files being present on disk are necessary for the scope to work correctly, as otherwise it will appear the scope is completely broken, and we'll get bug reports about the scope not showing any available apps when it gets installed in certain contexts.

I see no valid reason why ubuntu-sdk-libs should be removed as a dependency. It should never be uninstallable, and it provides files which are vital to the functionality of the click store scope. By definition, the dependency is correct.

review: Needs Information
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Right, it was found it's not currently possible since the ubuntu-sdk-libs contain the actual framework files in addition to being a meta package.

Unmerged revisions

305. By Timo Jyrinki

Drop the dependency instead.

304. By Timo Jyrinki

Switch to ubuntu-sdk-frameworks dependency (LP: #1399597)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/control'
--- debian/control 2014-10-10 17:45:50 +0000
+++ debian/control 2014-12-18 09:26:39 +0000
@@ -37,7 +37,6 @@
37 pay-service,37 pay-service,
38 ubuntu-app-launch-tools,38 ubuntu-app-launch-tools,
39 ubuntu-download-manager,39 ubuntu-download-manager,
40 ubuntu-sdk-libs,
41 unity-scope-click-departmentsdb (= ${binary:Version}),40 unity-scope-click-departmentsdb (= ${binary:Version}),
42 upstart-bin,41 upstart-bin,
43 ${misc:Depends},42 ${misc:Depends},


People subscribed via source and target branches

to all changes: