Merge lp:~timo-jyrinki/ubuntu/utopic/totem/enable_grilo_totem into lp:ubuntu/utopic/totem

Proposed by Timo Jyrinki
Status: Merged
Merge reported by: Iain Lane
Merged at revision: not available
Proposed branch: lp:~timo-jyrinki/ubuntu/utopic/totem/enable_grilo_totem
Merge into: lp:ubuntu/utopic/totem
Diff against target: 100 lines (+13/-20)
7 files modified
configure.ac (+1/-1)
debian/changelog (+9/-0)
debian/control (+1/-1)
debian/control.in (+1/-1)
debian/patches/93_grilo_optional.patch (+0/-16)
debian/patches/series (+0/-1)
debian/totem-plugins.install (+1/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu/utopic/totem/enable_grilo_totem
Reviewer Review Type Date Requested Status
Iain Lane Approve
Review via email: mp+219305@code.launchpad.net

Commit message

* Enable grilo for upnp/dlna support (LP: #1035701)
  - bring back libgrilo-0.2-dev build-dep
  - install grilo plugins
  - drop 93_grilo_optional.patch

To post a comment you must log in.
Revision history for this message
Doug McMahon (mc3man) wrote :

As mentioned (in bug), if actually going ahead then should take the opportunity to square up the plugin's control.in file > Description: ... as it's currently incorrect & these changes won't make it any less so.
(LP: #1313298

Revision history for this message
Iain Lane (laney) wrote :

Merged into ubuntu-desktop branch, thanks!

Sorry for not updating the description.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'configure.ac'
2--- configure.ac 2013-12-23 18:34:50 +0000
3+++ configure.ac 2014-05-13 08:21:37 +0000
4@@ -482,7 +482,7 @@
5 PKG_CHECK_MODULES(LIBGRILO, grilo-0.2 >= $GRILO_REQS,
6 [HAVE_LIBGRILO=yes], [HAVE_LIBGRILO=no])
7 if test "${HAVE_LIBGRILO}" != "yes" ; then
8- plugin_error_or_ignore "you need libgrilo >= $GRILO_REQS installed for the Grilo plugin"
9+ plugin_error "you need libgrilo >= $GRILO_REQS installed for the Grilo plugin"
10 add_plugin="0"
11 fi
12 ;;
13
14=== modified file 'debian/changelog'
15--- debian/changelog 2014-04-27 01:08:33 +0000
16+++ debian/changelog 2014-05-13 08:21:37 +0000
17@@ -1,3 +1,12 @@
18+totem (3.10.1-1ubuntu6) utopic; urgency=medium
19+
20+ * Enable grilo for upnp/dlna support (LP: #1035701)
21+ - bring back libgrilo-0.2-dev build-dep
22+ - install grilo plugins
23+ - drop 93_grilo_optional.patch
24+
25+ -- Tim Lunn <tim@feathertop.org> Mon, 12 May 2014 16:48:28 +1000
26+
27 totem (3.10.1-1ubuntu5) utopic; urgency=high
28
29 * No change rebuild against libcogl20.
30
31=== modified file 'debian/control'
32--- debian/control 2014-03-31 17:40:40 +0000
33+++ debian/control 2014-05-13 08:21:37 +0000
34@@ -33,7 +33,7 @@
35 libgdk-pixbuf2.0-dev (>= 2.23.0),
36 libgirepository1.0-dev (>= 0.9.12),
37 libglib2.0-dev (>= 2.33.0),
38-# libgrilo-0.2-dev,
39+ libgrilo-0.2-dev,
40 libgstreamer-plugins-base1.0-dev,
41 libgstreamer1.0-dev,
42 libgtk-3-dev (>= 3.5.2),
43
44=== modified file 'debian/control.in'
45--- debian/control.in 2014-02-20 11:40:43 +0000
46+++ debian/control.in 2014-05-13 08:21:37 +0000
47@@ -29,7 +29,7 @@
48 libgdk-pixbuf2.0-dev (>= 2.23.0),
49 libgirepository1.0-dev (>= 0.9.12),
50 libglib2.0-dev (>= 2.33.0),
51-# libgrilo-0.2-dev,
52+ libgrilo-0.2-dev,
53 libgstreamer-plugins-base1.0-dev,
54 libgstreamer1.0-dev,
55 libgtk-3-dev (>= 3.5.2),
56
57=== removed file 'debian/patches/93_grilo_optional.patch'
58--- debian/patches/93_grilo_optional.patch 2013-05-26 00:07:51 +0000
59+++ debian/patches/93_grilo_optional.patch 1970-01-01 00:00:00 +0000
60@@ -1,16 +0,0 @@
61-Description: Don't die if we can't build the grilo plugin. We should be MIRing grilo soon to make this no longer required.
62-Forwarded: not-needed
63-
64-Index: b/configure.ac
65-===================================================================
66---- a/configure.ac
67-+++ b/configure.ac
68-@@ -466,7 +466,7 @@
69- PKG_CHECK_MODULES(LIBGRILO, grilo-0.2 >= $GRILO_REQS,
70- [HAVE_LIBGRILO=yes], [HAVE_LIBGRILO=no])
71- if test "${HAVE_LIBGRILO}" != "yes" ; then
72-- plugin_error "you need libgrilo >= $GRILO_REQS installed for the Grilo plugin"
73-+ plugin_error_or_ignore "you need libgrilo >= $GRILO_REQS installed for the Grilo plugin"
74- add_plugin="0"
75- fi
76- ;;
77
78=== modified file 'debian/patches/series'
79--- debian/patches/series 2014-03-31 17:40:40 +0000
80+++ debian/patches/series 2014-05-13 08:21:37 +0000
81@@ -1,7 +1,6 @@
82 correct_desktop_mimetypes.patch
83 91_quicklist_entries.patch
84 92_gst-plugins-good.patch
85-93_grilo_optional.patch
86 revert_shell_menu.patch
87 git-fix-subtitle-downloader.patch
88 git_clutter_correct_use.patch
89
90=== modified file 'debian/totem-plugins.install'
91--- debian/totem-plugins.install 2013-12-23 18:34:50 +0000
92+++ debian/totem-plugins.install 2014-05-13 08:21:37 +0000
93@@ -5,6 +5,7 @@
94 usr/lib/totem/plugins/brasero-disc-recorder
95 usr/lib/totem/plugins/chapters
96 usr/lib/totem/plugins/dbus
97+usr/lib/totem/plugins/grilo
98 usr/lib/totem/plugins/im-status
99 usr/lib/totem/plugins/lirc
100 usr/lib/totem/plugins/media-player-keys

Subscribers

People subscribed via source and target branches

to all changes: