Merge lp:~timo-jyrinki/ubuntu/trusty/telepathy-qt5/fix_qt52_build into lp:ubuntu/trusty/telepathy-qt5

Proposed by Timo Jyrinki
Status: Merged
Merge reported by: Dmitry Shachnev
Merged at revision: not available
Proposed branch: lp:~timo-jyrinki/ubuntu/trusty/telepathy-qt5/fix_qt52_build
Merge into: lp:ubuntu/trusty/telepathy-qt5
Diff against target: 141 lines (+45/-26)
4 files modified
debian/changelog (+7/-0)
debian/libtelepathy-qt5-0.symbols (+24/-26)
debian/patches/05-fix-qt52-build.patch (+13/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu/trusty/telepathy-qt5/fix_qt52_build
Reviewer Review Type Date Requested Status
Dmitry Shachnev Approve
Ubuntu branches Pending
Review via email: mp+202239@code.launchpad.net

Commit message

debian/patches/05-fix-qt52-build.patch: build against both
Qt 5.0 and 5.2 (thanks to Albert) (LP: #1267835)

Description of the change

Qt 5.0 build tested locally, Qt 5.2 build at https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-daily/+sourcepub/3830635/+listing-archive-extra

Symbols updated for i386, amd64 and armhf from earlier LP build logs.

Update: Qt 5.0 PPA build: https://launchpad.net/~canonical-qt5-edgers/+archive/qt5-proper/+sourcepub/3835645/+listing-archive-extra

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks. I took the liberty to add a changelog entry for symbols update and some headers to the patch, and uploaded. Built on all archs now.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-06-08 22:02:16 +0000
3+++ debian/changelog 2014-01-20 04:58:34 +0000
4@@ -1,3 +1,10 @@
5+telepathy-qt5 (0.9.3-0ubuntu6) UNRELEASED; urgency=medium
6+
7+ * debian/patches/05-fix-qt52-build.patch: build against both
8+ Qt 5.0 and 5.2 (thanks to Albert) (LP: #1267835)
9+
10+ -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Fri, 17 Jan 2014 10:22:42 +0200
11+
12 telepathy-qt5 (0.9.3-0ubuntu5) saucy; urgency=low
13
14 * debian/libtelepathy-qt5-dev.install: should also install
15
16=== modified file 'debian/libtelepathy-qt5-0.symbols'
17--- debian/libtelepathy-qt5-0.symbols 2013-06-08 12:42:10 +0000
18+++ debian/libtelepathy-qt5-0.symbols 2014-01-20 04:58:34 +0000
19@@ -477,14 +477,14 @@
20 _ZN2Tp14SimpleObserverD0Ev@Base 0.9.3
21 _ZN2Tp14SimpleObserverD1Ev@Base 0.9.3
22 _ZN2Tp14SimpleObserverD2Ev@Base 0.9.3
23- _ZN2Tp14SimplePresenceC1ERKS0_@Base 0.9.3
24- _ZN2Tp14SimplePresenceC2ERKS0_@Base 0.9.3
25+ (arch=powerpc)_ZN2Tp14SimplePresenceC1ERKS0_@Base 0.9.3
26+ (arch=powerpc)_ZN2Tp14SimplePresenceC2ERKS0_@Base 0.9.3
27 _ZN2Tp14SimplePresenceD1Ev@Base 0.9.3
28 _ZN2Tp14SimplePresenceD2Ev@Base 0.9.3
29 _ZN2Tp14enableWarningsEb@Base 0.9.3
30 _ZN2Tp14enabledWarningEv@Base 0.9.3
31- _ZN2Tp15CallStateReasonC1ERKS0_@Base 0.9.3
32- _ZN2Tp15CallStateReasonC2ERKS0_@Base 0.9.3
33+ (arch=!armhf)_ZN2Tp15CallStateReasonC1ERKS0_@Base 0.9.3
34+ (arch=!armhf)_ZN2Tp15CallStateReasonC2ERKS0_@Base 0.9.3
35 _ZN2Tp15CallStateReasonD1Ev@Base 0.9.3
36 _ZN2Tp15CallStateReasonD2Ev@Base 0.9.3
37 _ZN2Tp15ClientRegistrar11qt_metacallEN11QMetaObject4CallEiPPv@Base 0.9.3
38@@ -1256,8 +1256,8 @@
39 _ZN2Tp27IncomingFileTransferChannelD2Ev@Base 0.9.3
40 _ZN2Tp27MediaStreamHandlerCandidateD1Ev@Base 0.9.3
41 _ZN2Tp27MediaStreamHandlerCandidateD2Ev@Base 0.9.3
42- (arch=armhf powerpc)_ZN2Tp27MediaStreamHandlerTransportC1ERKS0_@Base 0.9.3
43- (arch=armhf powerpc)_ZN2Tp27MediaStreamHandlerTransportC2ERKS0_@Base 0.9.3
44+ (arch=powerpc)_ZN2Tp27MediaStreamHandlerTransportC1ERKS0_@Base 0.9.3
45+ (arch=powerpc)_ZN2Tp27MediaStreamHandlerTransportC2ERKS0_@Base 0.9.3
46 _ZN2Tp27MediaStreamHandlerTransportD1Ev@Base 0.9.3
47 _ZN2Tp27MediaStreamHandlerTransportD2Ev@Base 0.9.3
48 _ZN2Tp27OutgoingFileTransferChannel11FeatureCoreE@Base 0.9.3
49@@ -1349,8 +1349,6 @@
50 (optional=templinst)_ZN2Tp5DebuglsINS_8FeaturesEEERS0_T_@Base 0.9.3
51 (optional=templinst)_ZN2Tp5DebuglsIPKNS_7ContactEEERS0_T_@Base 0.9.3
52 (optional=templinst|arch=!armhf !powerpc)_ZN2Tp5DebuglsIPNS_7ContactEEERS0_T_@Base 0.9.3
53- (arch=!armhf !powerpc)_ZN2Tp6AvatarC1ERKS0_@Base 0.9.3
54- (arch=!armhf !powerpc)_ZN2Tp6AvatarC2ERKS0_@Base 0.9.3
55 _ZN2Tp6AvatarD1Ev@Base 0.9.3
56 _ZN2Tp6AvatarD2Ev@Base 0.9.3
57 _ZN2Tp6Client14DebugInterface10invalidateEPNS_9DBusProxyERK7QStringS6_@Base 0.9.3
58@@ -4413,12 +4411,12 @@
59 _ZNK2Tp9DBusProxy19invalidationMessageEv@Base 0.9.3
60 _ZNK2Tp9DBusProxy7busNameEv@Base 0.9.3
61 _ZNK2Tp9DBusProxy7isValidEv@Base 0.9.3
62- _ZTI14QXmlDTDHandler@Base 0.9.3
63- _ZTI15QXmlDeclHandler@Base 0.9.3
64- _ZTI16QXmlErrorHandler@Base 0.9.3
65- _ZTI18QXmlContentHandler@Base 0.9.3
66- _ZTI18QXmlEntityResolver@Base 0.9.3
67- _ZTI18QXmlLexicalHandler@Base 0.9.3
68+ (arch=powerpc)_ZTI14QXmlDTDHandler@Base 0.9.3
69+ (arch=powerpc)_ZTI15QXmlDeclHandler@Base 0.9.3
70+ (arch=powerpc)_ZTI16QXmlErrorHandler@Base 0.9.3
71+ (arch=powerpc)_ZTI18QXmlContentHandler@Base 0.9.3
72+ (arch=powerpc)_ZTI18QXmlEntityResolver@Base 0.9.3
73+ (arch=powerpc)_ZTI18QXmlLexicalHandler@Base 0.9.3
74 _ZTIN2Tp10AccountSetE@Base 0.9.3
75 _ZTIN2Tp10CallStreamE@Base 0.9.3
76 _ZTIN2Tp10ConnectionE@Base 0.9.3
77@@ -4618,12 +4616,12 @@
78 _ZTIN2Tp7ContactE@Base 0.9.3
79 _ZTIN2Tp7ProfileE@Base 0.9.3
80 _ZTIN2Tp9DBusProxyE@Base 0.9.3
81- _ZTS14QXmlDTDHandler@Base 0.9.3
82- _ZTS15QXmlDeclHandler@Base 0.9.3
83- _ZTS16QXmlErrorHandler@Base 0.9.3
84- _ZTS18QXmlContentHandler@Base 0.9.3
85- _ZTS18QXmlEntityResolver@Base 0.9.3
86- _ZTS18QXmlLexicalHandler@Base 0.9.3
87+ (arch=powerpc)_ZTS14QXmlDTDHandler@Base 0.9.3
88+ (arch=powerpc)_ZTS15QXmlDeclHandler@Base 0.9.3
89+ (arch=powerpc)_ZTS16QXmlErrorHandler@Base 0.9.3
90+ (arch=powerpc)_ZTS18QXmlContentHandler@Base 0.9.3
91+ (arch=powerpc)_ZTS18QXmlEntityResolver@Base 0.9.3
92+ (arch=powerpc)_ZTS18QXmlLexicalHandler@Base 0.9.3
93 _ZTSN2Tp10AccountSetE@Base 0.9.3
94 _ZTSN2Tp10CallStreamE@Base 0.9.3
95 _ZTSN2Tp10ConnectionE@Base 0.9.3
96@@ -4826,12 +4824,12 @@
97 _ZTTN2Tp21AbstractClientHandlerE@Base 0.9.3
98 _ZTTN2Tp22AbstractClientApproverE@Base 0.9.3
99 _ZTTN2Tp22AbstractClientObserverE@Base 0.9.3
100- _ZTV14QXmlDTDHandler@Base 0.9.3
101- _ZTV15QXmlDeclHandler@Base 0.9.3
102- _ZTV16QXmlErrorHandler@Base 0.9.3
103- _ZTV18QXmlContentHandler@Base 0.9.3
104- _ZTV18QXmlEntityResolver@Base 0.9.3
105- _ZTV18QXmlLexicalHandler@Base 0.9.3
106+ (arch=powerpc)_ZTV14QXmlDTDHandler@Base 0.9.3
107+ (arch=powerpc)_ZTV15QXmlDeclHandler@Base 0.9.3
108+ (arch=powerpc)_ZTV16QXmlErrorHandler@Base 0.9.3
109+ (arch=powerpc)_ZTV18QXmlContentHandler@Base 0.9.3
110+ (arch=powerpc)_ZTV18QXmlEntityResolver@Base 0.9.3
111+ (arch=powerpc)_ZTV18QXmlLexicalHandler@Base 0.9.3
112 _ZTVN2Tp10AccountSetE@Base 0.9.3
113 _ZTVN2Tp10CallStreamE@Base 0.9.3
114 _ZTVN2Tp10ConnectionE@Base 0.9.3
115
116=== added file 'debian/patches/05-fix-qt52-build.patch'
117--- debian/patches/05-fix-qt52-build.patch 1970-01-01 00:00:00 +0000
118+++ debian/patches/05-fix-qt52-build.patch 2014-01-20 04:58:34 +0000
119@@ -0,0 +1,13 @@
120+=== modified file 'cmake/modules/TpQtMacros.cmake'
121+--- a/cmake/modules/TpQtMacros.cmake 2013-06-06 04:56:14 +0000
122++++ b/cmake/modules/TpQtMacros.cmake 2014-01-17 08:04:53 +0000
123+@@ -178,7 +178,7 @@
124+ function(TPQT_GENERATE_MOC_I infile outfile)
125+ qt5_get_moc_flags(moc_flags)
126+ get_filename_component(abs_infile ${infile} ABSOLUTE)
127+- qt5_create_moc_command(${abs_infile} ${outfile} "${moc_flags}" "-i")
128++ qt5_create_moc_command(${abs_infile} ${outfile} "${moc_flags}" "-i" "")
129+ set_source_files_properties(${outfile} PROPERTIES SKIP_AUTOMOC TRUE) # dont run automoc on this file
130+ endfunction(TPQT_GENERATE_MOC_I)
131+
132+
133
134=== modified file 'debian/patches/series'
135--- debian/patches/series 2013-06-06 04:56:14 +0000
136+++ debian/patches/series 2014-01-20 04:58:34 +0000
137@@ -2,3 +2,4 @@
138 02-adapt_to_work_with_q5_final.patch
139 03-add_service_side_classes.patch
140 04-force_PIC_QT5.patch
141+05-fix-qt52-build.patch

Subscribers

People subscribed via source and target branches

to all changes: