Merge lp:~timo-jyrinki/ubuntu/quantal/gnome-settings-daemon/ubuntu.fix1058004 into lp:ubuntu/quantal/gnome-settings-daemon

Proposed by Timo Jyrinki on 2012-10-02
Status: Rejected
Rejected by: Martin Pitt on 2012-11-23
Proposed branch: lp:~timo-jyrinki/ubuntu/quantal/gnome-settings-daemon/ubuntu.fix1058004
Merge into: lp:ubuntu/quantal/gnome-settings-daemon
Diff against target: 41 lines (+21/-0)
3 files modified
debian/changelog (+8/-0)
debian/patches/migrate_metacity_keys.patch (+12/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu/quantal/gnome-settings-daemon/ubuntu.fix1058004
Reviewer Review Type Date Requested Status
Jamie Strandboge Needs Fixing on 2012-10-15
Ubuntu branches 2012-10-02 Pending
Review via email: mp+127430@code.launchpad.net

Commit Message

* debian/patches/migrate_metacity_keys.patch:
  - Migrate screenshot/terminal keys from metacity gconf as well
    (LP: #1058004)

Description of the Change

Now that the (duplicate) keys were removed from org.compiz.integrated, they'd still need migrating from metacity settings. This branch does that, tested for the terminal key with gsettings-data-convert --verbose --file /usr/share/GConf/gsettings/gnome-settings-daemon.convert.

To post a comment you must log in.
Jamie Strandboge (jdstrand) wrote :

Thanks for the patch! I think this is worthwhile, but probably too late for 12.10 release. Since this only affects upgrades, an SRU is appropriate. Please update the bug following https://wiki.ubuntu.com/StableReleaseUpdates. Once that is done, please update this merge request to use 'quantal-proposed' instead of UNRELEASED.

review: Needs Fixing
Didier Roche (didrocks) wrote :

Hey Timo, I'm asking it to be removed from the sponsoring list for now. I think it's worthwhile for a SRU, can you please handle getting that into raring first, and make the bug SRUable (same procedure than for unity).

Thanks!

Unmerged revisions

230. By Timo Jyrinki on 2012-10-02

* debian/patches/migrate_metacity_keys.patch:
  - Migrate screenshot/terminal keys from metacity gconf as well
    (LP: #1058004)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-09-28 21:04:37 +0000
3+++ debian/changelog 2012-10-02 07:43:24 +0000
4@@ -1,3 +1,11 @@
5+gnome-settings-daemon (3.4.2-0ubuntu15) UNRELEASED; urgency=low
6+
7+ * debian/patches/migrate_metacity_keys.patch:
8+ - Migrate screenshot/terminal keys from metacity gconf as well
9+ (LP: #1058004)
10+
11+ -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Tue, 02 Oct 2012 09:42:56 +0300
12+
13 gnome-settings-daemon (3.4.2-0ubuntu14) quantal; urgency=low
14
15 * debian/patches/git_power_dbus_path.patch:
16
17=== added file 'debian/patches/migrate_metacity_keys.patch'
18--- debian/patches/migrate_metacity_keys.patch 1970-01-01 00:00:00 +0000
19+++ debian/patches/migrate_metacity_keys.patch 2012-10-02 07:43:24 +0000
20@@ -0,0 +1,12 @@
21+--- gnome-settings-daemon/data/gnome-settings-daemon.convert.old 2012-10-02 08:50:01.384413000 +0300
22++++ gnome-settings-daemon/data/gnome-settings-daemon.convert 2012-10-02 09:05:22.243096198 +0300
23+@@ -61,6 +61,9 @@
24+ volume-mute = /apps/gnome_settings_daemon/keybindings/volume_mute
25+ volume-up = /apps/gnome_settings_daemon/keybindings/volume_up
26+ www = /apps/gnome_settings_daemon/keybindings/www
27++screenshot = /apps/metacity/global_keybindings/run_command_screenshot
28++window-screenshot = /apps/metacity/global_keybindings/run_command_window_screenshot
29++terminal = /apps/metacity/global_keybindings/run_command_terminal
30+
31+ [org.gnome.settings-daemon.plugins.mouse]
32+ active = /apps/gnome_settings_daemon/plugins/mouse/active
33
34=== modified file 'debian/patches/series'
35--- debian/patches/series 2012-09-28 21:04:37 +0000
36+++ debian/patches/series 2012-10-02 07:43:24 +0000
37@@ -30,3 +30,4 @@
38 git_better_xi_handling.patch
39 git_new_cups_build.patch
40 git_power_dbus_path.patch
41+migrate_metacity_keys.patch

Subscribers

People subscribed via source and target branches

to all changes: