Merge lp:~timo-jyrinki/ubuntu-ui-toolkit/workaround_intel_autopilot_failure into lp:ubuntu-ui-toolkit

Proposed by Timo Jyrinki
Status: Merged
Approved by: Zsombor Egri
Approved revision: 495
Merged at revision: 495
Proposed branch: lp:~timo-jyrinki/ubuntu-ui-toolkit/workaround_intel_autopilot_failure
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 33 lines (+7/-1)
2 files modified
debian/changelog (+1/-1)
tests/autopilot/UbuntuUiToolkit/tests/gallery/test_gallery.py (+6/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-ui-toolkit/workaround_intel_autopilot_failure
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu SDK team Pending
Review via email: mp+163945@code.launchpad.net

Commit message

Try to workaround an autopilot failure on a slow Intel machine (LP: #1180226)

Description of the change

Try to workaround an autopilot failure on a slow Intel machine (LP: #1180226)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
494. By Timo Jyrinki

as discussed on IRC with zsombi, try sleep(0) first

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
495. By Timo Jyrinki

compromise, sleep(1)...

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Since it looks like a graphics related real delay, not some cache thing etc. I believe trying sleep(1) is better.

Furthermore, it may be possible to get direct access temporarily to a similar machine as the autopilot-intel machine, but it's not trivial. Therefore I'd like to first try if this patch changes anything, and if not then try other options.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-05-14 04:02:03 +0000
3+++ debian/changelog 2013-05-17 04:45:32 +0000
4@@ -1,4 +1,4 @@
5-ubuntu-ui-toolkit (0.1.46daily13.05.14ubuntu.unity.next-0ubuntu1) raring; urgency=low
6+ubuntu-ui-toolkit (0.1.46daily13.05.14ubuntu.unity.next-0ubuntu1~test1) raring; urgency=low
7
8 [ Zsombor Egri ]
9 * [Theming] custom styling objects which are owned by other styled
10
11=== modified file 'tests/autopilot/UbuntuUiToolkit/tests/gallery/test_gallery.py'
12--- tests/autopilot/UbuntuUiToolkit/tests/gallery/test_gallery.py 2013-05-13 07:37:40 +0000
13+++ tests/autopilot/UbuntuUiToolkit/tests/gallery/test_gallery.py 2013-05-17 04:45:32 +0000
14@@ -12,6 +12,7 @@
15 from testtools.matchers import Is, Not, Equals
16 from testtools import skip
17 import os
18+import time
19 from UbuntuUiToolkit.tests import UbuntuUiToolkitTestCase
20 from UbuntuUiToolkit.emulators.main_window import MainWindow
21
22@@ -63,6 +64,11 @@
23 # scroll view to expose more items
24 self.drag("Icons","Text Field")
25
26+ # Wait for the scrolling to finish, the next click fails on the
27+ # slower Intel machine but succeeds on AMD and NVIDIA.
28+ # (LP: #1180226)
29+ time.sleep(1)
30+
31 # now that we have more items, lets continue
32 items = [
33 "Dialog",

Subscribers

People subscribed via source and target branches

to status/vote changes: