Merge lp:~timo-jyrinki/ubuntu-terminal-app/add_ctrl_D_to_control_keys into lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot

Proposed by Timo Jyrinki
Status: Merged
Approved by: Filippo Scognamiglio
Approved revision: 73
Merged at revision: 73
Proposed branch: lp:~timo-jyrinki/ubuntu-terminal-app/add_ctrl_D_to_control_keys
Merge into: lp:~ubuntu-terminal-dev/ubuntu-terminal-app/reboot
Diff against target: 18 lines (+8/-0)
1 file modified
src/app/qml/KeyboardRows/Layouts/ControlKeys.json (+8/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-terminal-app/add_ctrl_D_to_control_keys
Reviewer Review Type Date Requested Status
Filippo Scognamiglio Approve
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Review via email: mp+256896@code.launchpad.net

Commit message

Add Ctrl-D to the control menu. (LP: #1446548)

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

I've also added Ctrl-P and Ctrl-N for irssi channel switching in my own configuration, but I understand if it feels to become too bloated with those too in the default config.

Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Filippo Scognamiglio (flscogna) wrote :

Thank you Timo. This is definitely handy. With respect to Ctrl-P and Ctrl-N, I believe we should bundle them into a specific irssi profile.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/app/qml/KeyboardRows/Layouts/ControlKeys.json'
2--- src/app/qml/KeyboardRows/Layouts/ControlKeys.json 2015-02-03 21:43:38 +0000
3+++ src/app/qml/KeyboardRows/Layouts/ControlKeys.json 2015-04-21 09:48:26 +0000
4@@ -34,6 +34,14 @@
5 "key" : "Z",
6 "mod" : "Control"
7 }
8+ },
9+ {
10+ "main_action" : {
11+ "type": "key",
12+ "text" : "CTRL+D",
13+ "key" : "D",
14+ "mod" : "Control"
15+ }
16 }
17 ]
18 }

Subscribers

People subscribed via source and target branches