Merge lp:~timo-jyrinki/ubuntu-system-settings/enable_multiarch into lp:ubuntu-system-settings

Proposed by Timo Jyrinki
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 229
Merged at revision: 229
Proposed branch: lp:~timo-jyrinki/ubuntu-system-settings/enable_multiarch
Merge into: lp:ubuntu-system-settings
Diff against target: 39 lines (+7/-3)
1 file modified
debian/control (+7/-3)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-system-settings/enable_multiarch
Reviewer Review Type Date Requested Status
Sebastien Bacher (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+178504@code.launchpad.net

Commit message

Enable Multi-Arch for the libraries (LP: #1208347)

Also change back to arch 'any' instead of listing archs.

Description of the change

Enable Multi-Arch for the libraries (LP: #1208347)

Also change back to arch 'any' instead of listing archs.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work, shouldn't the package have pre-depends on dpkg > multiarched-version though? Also the package doesn't really support multiarch, we didn't multiarch it but changed the paths in use to be more standard...

Revision history for this message
Sebastien Bacher (seb128) :
review: Needs Fixing
Revision history for this message
Sebastien Bacher (seb128) wrote :

(I meant "Pre-Depends: ${misc:Pre-Depends}" for the pre-depends of course)

229. By Timo Jyrinki

Add Pre-Depends dpkg (>= 1.15.6~), ${misc:Pre-Depends} for the multi-arch packages.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Ok. If enabling multi-arch still does no harm, added the Pre-Depends as well now.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Sebastien Bacher (seb128) wrote :

Looks good to me, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-08-01 15:29:45 +0000
3+++ debian/control 2013-08-05 08:03:24 +0000
4@@ -23,7 +23,7 @@
5 Vcs-Bzr: https://code.launchpad.net/~system-settings-touch/ubuntu-system-settings/trunk
6
7 Package: ubuntu-system-settings
8-Architecture: i386 amd64 armhf
9+Architecture: any
10 Depends: ${misc:Depends},
11 ${shlibs:Depends},
12 accountsservice,
13@@ -46,9 +46,11 @@
14
15 Package: libsystemsettings1
16 Section: libs
17-Architecture: i386 amd64 armhf
18+Architecture: any
19+Multi-Arch: same
20 Depends: ${misc:Depends},
21 ${shlibs:Depends},
22+Pre-Depends: dpkg (>= 1.15.6~), ${misc:Pre-Depends}
23 Description: System Settings Library for Ubuntu Touch
24 This package contains the System Settings application used on the
25 Ubuntu Touch images, it's designed for phones, tablets and convergent
26@@ -56,10 +58,12 @@
27
28 Package: libsystemsettings-dev
29 Section: libdevel
30-Architecture: i386 amd64 armhf
31+Architecture: any
32+Multi-Arch: same
33 Depends: ${misc:Depends},
34 ${shlibs:Depends},
35 libsystemsettings1 (= ${binary:Version}),
36+Pre-Depends: dpkg (>= 1.15.6~), ${misc:Pre-Depends}
37 Description: System Settings for Ubuntu Touch - development files
38 This package contains the System Settings application used on the
39 Ubuntu Touch images, it's designed for phones, tablets and convergent

Subscribers

People subscribed via source and target branches