Merge lp:~timo-jyrinki/ubuntu-system-settings-online-accounts/fix_qt52_tests into lp:ubuntu-system-settings-online-accounts

Proposed by Timo Jyrinki
Status: Merged
Approved by: Alberto Mardegan
Approved revision: 94
Merged at revision: 94
Proposed branch: lp:~timo-jyrinki/ubuntu-system-settings-online-accounts/fix_qt52_tests
Merge into: lp:ubuntu-system-settings-online-accounts
Diff against target: 59 lines (+5/-5)
5 files modified
tests/client/tst_client.pro (+1/-1)
tests/client/tst_qml_client.pro (+1/-1)
tests/online-accounts-ui/qml/qml.pro (+1/-1)
tests/online-accounts-ui/tst_inactivity_timer.pro (+1/-1)
tests/online-accounts-ui/tst_service.pro (+1/-1)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-system-settings-online-accounts/fix_qt52_tests
Reviewer Review Type Date Requested Status
Alberto Mardegan (community) Approve
PS Jenkins bot (community) continuous-integration Approve
Online Accounts Pending
Review via email: mp+202996@code.launchpad.net

Commit message

Use extra xvfb parameters to fix tests (LP: #1272198)

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks Timo!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/client/tst_client.pro'
2--- tests/client/tst_client.pro 2013-08-26 10:53:24 +0000
3+++ tests/client/tst_client.pro 2014-01-24 07:36:59 +0000
4@@ -21,6 +21,6 @@
5 QMAKE_RPATHDIR = $${QMAKE_LIBDIR}
6 LIBS += -lonline-accounts-client
7
8-check.commands = "xvfb-run -a dbus-test-runner -t ./$${TARGET}"
9+check.commands = "xvfb-run -s '-screen 0 640x480x24' -a dbus-test-runner -t ./$${TARGET}"
10 check.depends = $${TARGET}
11 QMAKE_EXTRA_TARGETS += check
12
13=== modified file 'tests/client/tst_qml_client.pro'
14--- tests/client/tst_qml_client.pro 2013-08-26 10:53:24 +0000
15+++ tests/client/tst_qml_client.pro 2014-01-24 07:36:59 +0000
16@@ -20,6 +20,6 @@
17 DEFINES += \
18 PLUGIN_PATH=\\\"$${PLUGIN_PATH}\\\"
19
20-check.commands = "LD_LIBRARY_PATH=$${TOP_BUILD_DIR}/client/OnlineAccountsClient:${LD_LIBRARY_PATH} xvfb-run -a dbus-test-runner -t ./$${TARGET}"
21+check.commands = "LD_LIBRARY_PATH=$${TOP_BUILD_DIR}/client/OnlineAccountsClient:${LD_LIBRARY_PATH} xvfb-run -s '-screen 0 640x480x24' -a dbus-test-runner -t ./$${TARGET}"
22 check.depends = $${TARGET}
23 QMAKE_EXTRA_TARGETS += check
24
25=== modified file 'tests/online-accounts-ui/qml/qml.pro'
26--- tests/online-accounts-ui/qml/qml.pro 2013-09-19 08:08:22 +0000
27+++ tests/online-accounts-ui/qml/qml.pro 2014-01-24 07:36:59 +0000
28@@ -9,6 +9,6 @@
29 SOURCES += \
30 tst_online_accounts_qml.cpp
31
32-check.commands = "xvfb-run -a dbus-test-runner -t "
33+check.commands = "xvfb-run -s '-screen 0 640x480x24' -a dbus-test-runner -t "
34 check.depends = $${TARGET}
35 QMAKE_EXTRA_TARGETS += check
36
37=== modified file 'tests/online-accounts-ui/tst_inactivity_timer.pro'
38--- tests/online-accounts-ui/tst_inactivity_timer.pro 2013-09-11 07:34:28 +0000
39+++ tests/online-accounts-ui/tst_inactivity_timer.pro 2014-01-24 07:36:59 +0000
40@@ -19,6 +19,6 @@
41 INCLUDEPATH += \
42 $${TOP_SRC_DIR}/src
43
44-check.commands = "xvfb-run -a ./$${TARGET}"
45+check.commands = "xvfb-run -s '-screen 0 640x480x24' -a ./$${TARGET}"
46 check.depends = $${TARGET}
47 QMAKE_EXTRA_TARGETS += check
48
49=== modified file 'tests/online-accounts-ui/tst_service.pro'
50--- tests/online-accounts-ui/tst_service.pro 2013-09-17 09:36:46 +0000
51+++ tests/online-accounts-ui/tst_service.pro 2014-01-24 07:36:59 +0000
52@@ -29,6 +29,6 @@
53 INCLUDEPATH += \
54 $${TOP_SRC_DIR}/src
55
56-check.commands = "xvfb-run -a dbus-test-runner -t ./$${TARGET}"
57+check.commands = "xvfb-run -s '-screen 0 640x480x24' -a dbus-test-runner -t ./$${TARGET}"
58 check.depends = $${TARGET}
59 QMAKE_EXTRA_TARGETS += check

Subscribers

People subscribed via source and target branches