Merge lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.wily_remove_friends into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.wily
| Status: | Approved |
|---|---|
| Approved by: | Ken VanDine on 2015-08-18 |
| Approved revision: | 310 |
| Proposed branch: | lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.wily_remove_friends |
| Merge into: | lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.wily |
| Diff against target: |
13 lines (+0/-3) 1 file modified
touch-core (+0/-3) |
| To merge this branch: | bzr merge lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.wily_remove_friends |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Robert Bruce Park (community) | 2015-08-18 | Approve on 2015-08-24 | |
| Ken VanDine | 2015-08-11 | Approve on 2015-08-18 | |
| Łukasz Zemczak | Approve on 2015-08-11 | ||
|
Review via email:
|
|||
Commit Message
Drop obsolete friends packages. (LP: #1483674)
| Robert Bruce Park (robru) wrote : | # |
Ok with popey's help I've done an audit of apps that reference Friends:
$ ack Friends
com.ubuntu.
26:import Friends 0.2
36: FriendsDispatcher {
com.ubuntu.
82: title: "Friends"
83: page: FriendsPage {
com.ubuntu.
4:import Friends 0.1
141: FriendsDispatcher
com.wellsb.
5:import Friends 0.2
14: FriendsDispatcher {
I'll email these people.
| Robert Bruce Park (robru) wrote : | # |
oh actually i think the mzanetti one is a false positive since he's not actually importing Friends.
| Robert Bruce Park (robru) wrote : | # |
Brad Wells says he'll "see what he can do". Got an out-of-office autoresponder from Rick. No response from Andrew yet.
| Robert Bruce Park (robru) wrote : | # |
Rick says his app doesn't need Friends so I think we should just do this and get it over with.
Unmerged revisions
- 310. By Timo Jyrinki on 2015-08-11
-
Drop obsolete friends packages. (LP: #1483674)

+1 from my side, but we need to confirm with the developer if it's still useful to have before merging in.