Merge lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.wily_remove_friends into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.wily

Proposed by Timo Jyrinki
Status: Approved
Approved by: Ken VanDine
Approved revision: 310
Proposed branch: lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.wily_remove_friends
Merge into: lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.wily
Diff against target: 13 lines (+0/-3)
1 file modified
touch-core (+0/-3)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.wily_remove_friends
Reviewer Review Type Date Requested Status
Robert Bruce Park (community) Approve
Ken VanDine Approve
Łukasz Zemczak Approve
Review via email: mp+267648@code.launchpad.net

Commit message

Drop obsolete friends packages. (LP: #1483674)

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

+1 from my side, but we need to confirm with the developer if it's still useful to have before merging in.

review: Approve
Revision history for this message
Robert Bruce Park (robru) wrote :

Yes please.

review: Approve
Revision history for this message
Ken VanDine (ken-vandine) wrote :

+1 from me

review: Approve
Revision history for this message
Robert Bruce Park (robru) wrote :

Ok with popey's help I've done an audit of apps that reference Friends:

$ ack Friends
com.ubuntu.developer.andrewsomething.stackbrowser_0.3.2_all.click-dir/components/ShareComponent.qml
26:import Friends 0.2
36: FriendsDispatcher {

com.ubuntu.developer.mzanetti.ubuntu-fitbit-app_0.4_armhf.click-dir/share/qml/ufit/ufit.qml
82: title: "Friends"
83: page: FriendsPage {

com.ubuntu.developer.rick-rickspencer3.reddgur_0.5_all.click-dir/components/Overlay.qml
4:import Friends 0.1
141: FriendsDispatcher

com.wellsb.blackjack-app_0.0.1.4_all.click-dir/blackjack/ShareDialog.qml
5:import Friends 0.2
14: FriendsDispatcher {

I'll email these people.

Revision history for this message
Robert Bruce Park (robru) wrote :

oh actually i think the mzanetti one is a false positive since he's not actually importing Friends.

Revision history for this message
Robert Bruce Park (robru) wrote :

Brad Wells says he'll "see what he can do". Got an out-of-office autoresponder from Rick. No response from Andrew yet.

Revision history for this message
Robert Bruce Park (robru) wrote :

Rick says his app doesn't need Friends so I think we should just do this and get it over with.

review: Approve

Unmerged revisions

310. By Timo Jyrinki

Drop obsolete friends packages. (LP: #1483674)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'touch-core'
2--- touch-core 2015-07-16 10:03:57 +0000
3+++ touch-core 2015-08-11 11:56:54 +0000
4@@ -19,9 +19,6 @@
5 * alsa-utils
6 * powerd
7 * urfkill
8- * qtdeclarative5-friends0.2
9- * friends-facebook
10- * friends-twitter
11 * telepathy-gabble
12 * telepathy-ofono-ril-mc-plugin
13 * libmessaging-menu0

Subscribers

People subscribed via source and target branches