Merge lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.remove-qt5default into lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.saucy

Proposed by Timo Jyrinki
Status: Merged
Merge reported by: Oliver Grawert
Merged at revision: not available
Proposed branch: lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.remove-qt5default
Merge into: lp:~ubuntu-core-dev/ubuntu-seeds/ubuntu-touch.saucy
Diff against target: 11 lines (+0/-1)
1 file modified
touch (+0/-1)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-seeds/ubuntu-touch.remove-qt5default
Reviewer Review Type Date Requested Status
Sergio Schvezov (community) Approve
Dimitri John Ledkov Abstain
Canonical Phone Foundations Pending
Oliver Grawert Pending
Review via email: mp+165291@code.launchpad.net

Commit message

Remove qt5-default. (LP: #1183150)

It comes as part of the ubuntu-sdk for developers, but device images
shouldn't contain them by default. Qtchooser in itself is harmless in
terms of dependencies and is also small, and should be left on images.

The main reason for including qt5-default was the use of qmlscene from a
symlink in /usr/bin instead of the full path. With qtbase and qtchooser
changes uploaded to saucy, qtchooser can be used properly without -dev
packages or qt5-default.

Description of the change

Remove qt5-default. (LP: #1183150)

It comes as part of the ubuntu-sdk for developers, but device images
shouldn't contain them by default. Qtchooser in itself is harmless in
terms of dependencies and is also small, and should be left on images.

The main reason for including qt5-default was the use of qmlscene from a
symlink in /usr/bin instead of the full path. With qtbase and qtchooser
changes uploaded to saucy, qtchooser can be used properly without -dev
packages or qt5-default.

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

This seems premature? qmlrunner isn't in saucy yet.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Michael: A valid point, it's in the SDK Release PPA but no ubuntu-ui-toolkit uploads to saucy have yet been done. The saucy device images are still created with PPA:s enabled, but that should go away at the same time everything is gotten to the archives.

13. By Timo Jyrinki

Merge with trunk.

14. By Timo Jyrinki

Restore qtchooser, only qt5-default should be removed.

With the newest Qt5 and qtchooser changes uploaded to saucy, qmlrunner
is not going to be used anymore. qt5-default should still be removed
to prevent needless installation of -dev packages. At the same time,
qmlrunner usage is made obsolete by having qtchooser's configuration
now as part of core libraries.

Accepting this and keeping qmlscene using programs working still requires
either setting QT_SELECT=qt5 globally, or by per app basis setting that
or calling qmlscene with 'qmlscene -qt=qt5 file.qml'.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Subscribed Sergio who has the "Using qmlscene without qt5-default & qtbase5-dev" in his inbox from a week ago. Raring is already frozen, so we only consider saucy.

This should be accepted when either the QT_SELECT=qt5 is set globally or the apps using /usr/bin/qmlscene have been updated accordingly.

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Claiming ubuntu-core-dev review, just to get this item from the sponsorship queue. As far as I can tell this is for PhoneFoundations to decide when to apply, as the images are still built with PPAs enabled as far as I know. Requested PhoneFoundations review instead.

review: Abstain
Revision history for this message
Sergio Schvezov (sergiusens) wrote :

I approve of this, but would add
QT_SELECT=qt5
in
/etc/environment

review: Approve
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

> I approve of this, but would add
> QT_SELECT=qt5
> in
> /etc/environment

Why would that be needed? seems like a very odd place. Is debian going to use /etc/environment?

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Wouldn't that break all existing qt4 packages in the archive that haven't been migrated to use QT_SELECT?

Revision history for this message
Oliver Grawert (ogra) wrote :

On Do, 2013-06-13 at 17:58 +0000, Dmitrijs Ledkovs wrote:
> > I approve of this, but would add
> > QT_SELECT=qt5
> > in
> > /etc/environment
>
> Why would that be needed? seems like a very odd place. Is debian going to use /etc/environment?

i doubt debian will use the ubuntu-touch seeds in the foreseeable
future :)

Revision history for this message
Sergio Schvezov (sergiusens) wrote :

> Wouldn't that break all existing qt4 packages in the archive that haven't been
> migrated to use QT_SELECT?

sorry for not being specific, but just in Ubuntu Touch, a proper solution to clear /etc/environment is still pending

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

The proper solution would be that applications would call qmlscene with '-qt=qt5' parameter or set the environment variable themselves, but I suggested the global setting as a workaround to make this change transparent.

A later proper solution will be to move to te new upstream 'qml' tool, when released.

Revision history for this message
Oliver Grawert (ogra) wrote :

added teh necessary changes to livecd-rootfs ... merged

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'touch'
2--- touch 2013-06-05 14:05:43 +0000
3+++ touch 2013-06-07 09:04:27 +0000
4@@ -65,7 +65,6 @@
5
6 * hud
7 * qtubuntu
8- * qt5-default
9 * qtchooser
10 * qtdeclarative5-ubuntu-ui-toolkit-plugin
11 * webbrowser-app

Subscribers

People subscribed via source and target branches