Merge lp:~timo-jyrinki/ubuntu-html5-theme/more_missing_autopilot_dependencies into lp:~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance

Proposed by Timo Jyrinki
Status: Merged
Approved by: Didier Roche-Tolomelli
Approved revision: 61
Merged at revision: 61
Proposed branch: lp:~timo-jyrinki/ubuntu-html5-theme/more_missing_autopilot_dependencies
Merge into: lp:~ubuntu-html5-theme-devs/ubuntu-html5-theme/ambiance
Diff against target: 16 lines (+2/-0)
1 file modified
debian/control (+2/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/ubuntu-html5-theme/more_missing_autopilot_dependencies
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Didier Roche-Tolomelli (community) Approve
Review via email: mp+173408@code.launchpad.net

Commit message

Add further missing dependencies to the autopilot package.

Description of the change

Add further missing dependencies to the autopilot package.

Not strictly required in our cu2d setup, but still worth adding.

Note that the autopilot tests are still failing, and this doesn't fix those. The tests run locally just fine, but on the test setup for some reason the pages don't load and the tests fail on waiting the page to load.

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

Thanks!

review: Approve
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

for the record:
didrocks | dpkg-dev?
didrocks | Mirv: why is it a runtime dep? ^
didrocks | (we don't dpkg-source, isn't it?)
    Mirv | didrocks: same as ui-toolkit, the autopilot code runs dpkg -qDEB_HOST_MULTIARCH to find out the deep path to
         | qmlscene

Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2013-07-05 14:14:36 +0000
3+++ debian/control 2013-07-08 06:41:24 +0000
4@@ -31,10 +31,12 @@
5 Architecture: all
6 Depends: ${misc:Depends},
7 ${python:Depends},
8+ dpkg-dev,
9 libautopilot-qt,
10 libqt5test5,
11 libqt5webkit5-qmlwebkitplugin,
12 qmlscene,
13+ qtdeclarative5-qtquick2-plugin,
14 ubuntu-html5-theme (= ${binary:Version}),
15 ubuntu-html5-theme-examples (= ${binary:Version}),
16 Description: Autopilot tests for the Toolkit for Ubuntu HTML5 Apps

Subscribers

People subscribed via source and target branches