Merge lp:~timo-jyrinki/qtubuntu-camera/support_new_audiorole_api into lp:qtubuntu-camera

Proposed by Timo Jyrinki
Status: Superseded
Proposed branch: lp:~timo-jyrinki/qtubuntu-camera/support_new_audiorole_api
Merge into: lp:qtubuntu-camera
Diff against target: 15 lines (+4/-0)
1 file modified
src/aalimagecapturecontrol.cpp (+4/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/qtubuntu-camera/support_new_audiorole_api
Reviewer Review Type Date Requested Status
Jim Hodapp (community) code Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+273791@code.launchpad.net

This proposal has been superseded by a proposal from 2015-11-25.

Commit message

Support the new AudioRole API in addition to the old (LP: #1493851) (LP: #1450346)

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Jim Hodapp (jhodapp) wrote :

LGTM

review: Approve (code)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/aalimagecapturecontrol.cpp'
2--- src/aalimagecapturecontrol.cpp 2015-07-06 18:22:43 +0000
3+++ src/aalimagecapturecontrol.cpp 2015-10-08 08:17:40 +0000
4@@ -51,7 +51,11 @@
5 {
6 m_galleryPath = QStandardPaths::writableLocation(QStandardPaths::PicturesLocation);
7 m_audioPlayer->setMedia(QUrl::fromLocalFile("/system/media/audio/ui/camera_click.ogg"));
8+#if QT_VERSION < QT_VERSION_CHECK(5, 5, 0)
9 m_audioPlayer->setAudioRole(QMediaPlayer::AlertRole);
10+#else
11+ m_audioPlayer->setAudioRole(QAudio::NotificationRole);
12+#endif
13 }
14
15 AalImageCaptureControl::~AalImageCaptureControl()

Subscribers

People subscribed via source and target branches