Merge lp:~timo-jyrinki/qtgrilo/fix_lp1287180 into lp:qtgrilo

Proposed by Timo Jyrinki
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 15
Merged at revision: 15
Proposed branch: lp:~timo-jyrinki/qtgrilo/fix_lp1287180
Merge into: lp:qtgrilo
Diff against target: 89 lines (+27/-1)
6 files modified
debian/changelog (+19/-0)
debian/control (+0/-1)
declarative/grilodatasource.h (+2/-0)
declarative/grilomedia.h (+2/-0)
declarative/griloplugin.h (+2/-0)
declarative/griloregistry.h (+2/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/qtgrilo/fix_lp1287180
Reviewer Review Type Date Requested Status
Victor Thompson Approve
Review via email: mp+209222@code.launchpad.net

Commit message

Prevent 'signals' from GDBus from clashing with Qt's 'signals' (LP: #1287180)

Description of the change

Obviously a hack, and I'm not familiar with qtgrilo.

To post a comment you must log in.
13. By Timo Jyrinki

Add comments to the ugly hacks.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :
Revision history for this message
Victor Thompson (vthompson) wrote :

A hack is very acceptable in this case--since we'll be moving away from qtgrilo shortly. Thanks Timo!

review: Approve
14. By Timo Jyrinki

Sync debian/ with what is in the archives already.

15. By Timo Jyrinki

Add changelog entry for 0.0.20130610-0ubuntu3

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-09-09 09:21:45 +0000
3+++ debian/changelog 2014-03-05 08:20:23 +0000
4@@ -1,3 +1,22 @@
5+qtgrilo (0.0.20130610-0ubuntu3) trusty; urgency=medium
6+
7+ * Rebuild against Qt 5.2.1
8+ * Prevent 'signals' from GDBus from clashing with Qt's 'signals'
9+ (LP: #1287180)
10+
11+ -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Wed, 05 Mar 2014 10:19:57 +0200
12+
13+qtgrilo (0.0.20130610-0ubuntu2) saucy; urgency=low
14+
15+ * New bzr checkout.
16+ - Changes recommended from upstream after they included the changes to add
17+ genre, cover art, year and track number.
18+ - Fix the import path after adding versioning to the installation path and
19+ the Debian package.
20+ - Add trackNumber property to order tracks.
21+
22+ -- Victor Thompson <victor.thompson@gmail.com> Wed, 18 Sep 2013 13:32:54 -0500
23+
24 qtgrilo (0.0.20130610-0ubuntu1) saucy; urgency=low
25
26 * Initial release.
27
28=== modified file 'debian/control'
29--- debian/control 2013-11-14 19:44:39 +0000
30+++ debian/control 2014-03-05 08:20:23 +0000
31@@ -8,7 +8,6 @@
32 qt5-default,
33 pkg-kde-tools,
34 libgrilo-0.2-dev,
35- mediascanner,
36 Standards-Version: 3.9.4
37 Homepage: http://qt-project.org/
38
39
40=== modified file 'declarative/grilodatasource.h'
41--- declarative/grilodatasource.h 2013-08-15 23:52:19 +0000
42+++ declarative/grilodatasource.h 2014-03-05 08:20:23 +0000
43@@ -24,6 +24,8 @@
44 #ifndef GRILO_DATA_SOURCE_H
45 #define GRILO_DATA_SOURCE_H
46
47+/* Fix FTBFS from clashing 'signals' definition (LP: #1287180) */
48+#define __G_DBUS_INTROSPECTION_H__
49 #include <QObject>
50 #include <grilo.h>
51 #include <QVariant>
52
53=== modified file 'declarative/grilomedia.h'
54--- declarative/grilomedia.h 2013-09-14 02:09:24 +0000
55+++ declarative/grilomedia.h 2014-03-05 08:20:23 +0000
56@@ -24,6 +24,8 @@
57 #ifndef GRILO_MEDIA_H
58 #define GRILO_MEDIA_H
59
60+/* Fix FTBFS from clashing 'signals' definition (LP: #1287180) */
61+#define __G_DBUS_INTROSPECTION_H__
62 #include <QObject>
63 #include <grilo.h>
64 #include <QUrl>
65
66=== modified file 'declarative/griloplugin.h'
67--- declarative/griloplugin.h 2013-08-15 23:52:19 +0000
68+++ declarative/griloplugin.h 2014-03-05 08:20:23 +0000
69@@ -26,6 +26,8 @@
70 #include <QtGlobal>
71
72 #if QT_VERSION >= QT_VERSION_CHECK(5, 0, 0)
73+/* Fix FTBFS from clashing 'signals' definition (LP: #1287180) */
74+# define __G_DBUS_INTROSPECTION_H__
75 # include <QQmlExtensionPlugin>
76 # define QDeclarativeExtensionPlugin QQmlExtensionPlugin
77 #else
78
79=== modified file 'declarative/griloregistry.h'
80--- declarative/griloregistry.h 2013-08-15 23:52:19 +0000
81+++ declarative/griloregistry.h 2014-03-05 08:20:23 +0000
82@@ -24,6 +24,8 @@
83 #ifndef GRILO_REGISTRY_H
84 #define GRILO_REGISTRY_H
85
86+/* Fix FTBFS from clashing 'signals' definition (LP: #1287180) */
87+#define __G_DBUS_INTROSPECTION_H__
88 #include <QObject>
89 #include <grilo.h>
90

Subscribers

People subscribed via source and target branches