Merge lp:~timo-jyrinki/oxide/prefer_codecs_extras_lp1399597 into lp:~oxide-developers/oxide/packaging.vivid

Proposed by Timo Jyrinki
Status: Needs review
Proposed branch: lp:~timo-jyrinki/oxide/prefer_codecs_extras_lp1399597
Merge into: lp:~oxide-developers/oxide/packaging.vivid
Diff against target: 57 lines (+23/-9)
2 files modified
debian/changelog (+21/-7)
debian/control (+2/-2)
To merge this branch: bzr merge lp:~timo-jyrinki/oxide/prefer_codecs_extras_lp1399597
Reviewer Review Type Date Requested Status
Chris Coulson Disapprove
Review via email: mp+243946@code.launchpad.net

Commit message

* Use the new conflict arrangement still, but change the dependency
  order of Oxide's own codecs packages to prefer the -extras.
  This should hopefully solve the problem when setting up the
  autopkgtest environment with packages that have a hard depedency
  on the -extras package. (LP: #1399597)

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

This is what's waiting in the PPA. The changelog inflation is because of various archive + PPA uploads and the 5h build times. The current version in the archives is already ubuntu4.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

< oSoMoN> Mirv, if swapping the order fixes the issue, then go for it, but it would be good to get to the bottom of things, we shouldn’t have to do this kind of things in the first place

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

One interesting comment worth considering if the normal preferring of non-extra package would be wanted to be kept in Oxide itself while others depend on the -extra package:

< RAOF> Hm, odd. I suppose that also arch-specifying the Replaces: was tried?

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

This change isn't really acceptable - it will result in -extras being pulled in to the desktop seed. Avoiding this is the reason that there are 2 codecs packages

review: Disapprove
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

(this got approved by raof on IRC earlier)

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

And it's rejected by me (the Oxide maintainer). This results in proprietary codecs being pulled in to the desktop image

Unmerged revisions

57. By Timo Jyrinki

* Use the new conflict arrangement still, but change the dependency
  order of Oxide's own codecs packages to prefer the -extras.
  This should hopefully solve the problem when setting up the
  autopkgtest environment with packages that have a hard depedency
  on the -extras package. (LP: #1399597)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-12-03 10:47:36 +0000
3+++ debian/changelog 2014-12-08 06:26:05 +0000
4@@ -1,10 +1,24 @@
5-oxide-qt (1.3.5-0ubuntu2) vivid; urgency=medium
6-
7- [ Zoltan Balogh <zoltan.balogh@canonical.com> ]
8- * Fix the Click chroot by limiting the codecs vs. codecs-extra conlict
9- for the same arch only
10-
11- -- Chris Coulson <chris.coulson@canonical.com> Wed, 03 Dec 2014 10:42:54 +0000
12+oxide-qt (1.3.5-0ubuntu6) vivid; urgency=medium
13+
14+ * Use the new conflict arrangement still, but change the dependency
15+ order of Oxide's own codecs packages to prefer the -extras.
16+ This should hopefully solve the problem when setting up the
17+ autopkgtest environment with packages that have a hard depedency
18+ on the -extras package. (LP: #1399597)
19+
20+ -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Fri, 05 Dec 2014 13:39:34 +0000
21+
22+oxide-qt (1.3.5-0ubuntu5) vivid; urgency=medium
23+
24+ * Revert previous upload because of autopkgtest failures (LP: #1399597)
25+
26+ -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Fri, 05 Dec 2014 10:09:07 +0000
27+
28+oxide-qt (1.3.5-0ubuntu4) vivid; urgency=medium
29+
30+ * Add arch specific conflict to the oxideqt-codecs and oxideqt-codecs-extra
31+
32+ -- Zoltán Balogh <zoltan.balogh@canonical.com> Wed, 03 Dec 2014 11:36:04 +0000
33
34 oxide-qt (1.3.5-0ubuntu1) vivid; urgency=medium
35
36
37=== modified file 'debian/control'
38--- debian/control 2014-12-03 10:38:29 +0000
39+++ debian/control 2014-12-08 06:26:05 +0000
40@@ -48,7 +48,7 @@
41 Architecture: any
42 Multi-Arch: same
43 Depends: ${shlibs:Depends}, ${misc:Depends},
44- oxideqt-codecs (= ${binary:Version}) | oxideqt-codecs-extra (= ${binary:Version})
45+ oxideqt-codecs-extra (= ${binary:Version}) | oxideqt-codecs (= ${binary:Version})
46 Description: Web browser engine library for Qt (core library and components)
47 Oxide is a web browser engine library based on Google Chromium, that makes
48 it easy to embed web content in your Qt application
49@@ -61,7 +61,7 @@
50 Multi-Arch: same
51 Depends: ${shlibs:Depends}, ${misc:Depends},
52 liboxideqtcore0 (= ${binary:Version}),
53- oxideqt-codecs (= ${binary:Version}) | oxideqt-codecs-extra (= ${binary:Version})
54+ oxideqt-codecs-extra (= ${binary:Version}) | oxideqt-codecs (= ${binary:Version})
55 Description: Web browser engine library for Qt (QtQuick library)
56 Oxide is a web browser engine library based on Google Chromium, that makes
57 it easy to embed web content in your Qt application

Subscribers

People subscribed via source and target branches

to all changes: