Merge lp:~timo-jyrinki/os-prober/trusty_add_win10_to_the_list into lp:ubuntu/trusty-proposed/os-prober

Proposed by Timo Jyrinki on 2015-12-20
Status: Merged
Merge reported by: Mathieu Trudel-Lapierre
Merged at revision: not available
Proposed branch: lp:~timo-jyrinki/os-prober/trusty_add_win10_to_the_list
Merge into: lp:ubuntu/trusty-proposed/os-prober
Diff against target: 30 lines (+11/-1)
2 files modified
debian/changelog (+8/-0)
os-probes/mounted/x86/20microsoft (+3/-1)
To merge this branch: bzr merge lp:~timo-jyrinki/os-prober/trusty_add_win10_to_the_list
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre 2015-12-20 Approve on 2016-01-12
Review via email: mp+281040@code.launchpad.net

Commit Message

  * os-probes/mounted/x86/20microsoft:
    - add Windows 10 to the list (thanks for David Martin for the patch!)
      (LP: #1482851)

To post a comment you must log in.
Timo Jyrinki (timo-jyrinki) wrote :

I managed to get now an access to what's needed to test it, and it seems to fix it - applying it manually in a live session makes it possible to install Ubuntu alongside Win10, otherwise it's not possible.

Likewise with this applied update-grub works correctly after the installation.

Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-02-13 11:24:13 +0000
3+++ debian/changelog 2015-12-20 20:06:50 +0000
4@@ -1,3 +1,11 @@
5+os-prober (1.63ubuntu1.1) trusty; urgency=medium
6+
7+ * os-probes/mounted/x86/20microsoft:
8+ - add Windows 10 to the list (thanks for David Martin for the patch!)
9+ (LP: #1482851)
10+
11+ -- Timo Jyrinki <timo-jyrinki@ubuntu.com> Sun, 20 Dec 2015 21:49:21 +0200
12+
13 os-prober (1.63ubuntu1) trusty; urgency=medium
14
15 * Resynchronise with Debian. Remaining changes:
16
17=== modified file 'os-probes/mounted/x86/20microsoft'
18--- os-probes/mounted/x86/20microsoft 2013-05-20 12:42:06 +0000
19+++ os-probes/mounted/x86/20microsoft 2015-12-20 20:06:50 +0000
20@@ -31,7 +31,9 @@
21 for boot in $(item_in_dir boot "$2"); do
22 bcd=$(item_in_dir bcd "$2/$boot")
23 if [ -n "$bcd" ]; then
24- if grep -qs "W.i.n.d.o.w.s. .8" "$2/$boot/$bcd"; then
25+ if grep -qs "W.i.n.d.o.w.s. .1.0" "$2/$boot/$bcd"; then
26+ long="Windows 10 (loader)"
27+ elif grep -qs "W.i.n.d.o.w.s. .8" "$2/$boot/$bcd"; then
28 long="Windows 8 (loader)"
29 elif grep -qs "W.i.n.d.o.w.s. .7" "$2/$boot/$bcd"; then
30 long="Windows 7 (loader)"

Subscribers

People subscribed via source and target branches

to all changes: