Merge lp:~timo-jyrinki/libusermetrics/dont-share-dbus-sessionbus-connections into lp:libusermetrics

Proposed by Timo Jyrinki
Status: Rejected
Rejected by: Timo Jyrinki
Proposed branch: lp:~timo-jyrinki/libusermetrics/dont-share-dbus-sessionbus-connections
Merge into: lp:libusermetrics
Diff against target: 40 lines (+6/-3)
3 files modified
src/usermetricsservice/DBusDataSet.cpp (+2/-1)
src/usermetricsservice/DBusDataSource.cpp (+2/-1)
src/usermetricsservice/DBusUserData.cpp (+2/-1)
To merge this branch: bzr merge lp:~timo-jyrinki/libusermetrics/dont-share-dbus-sessionbus-connections
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Unity Team Pending
Review via email: mp+257505@code.launchpad.net

Commit message

Stop using shared DBus connections

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Unmerged revisions

193. By Timo Jyrinki

Stop using shared DBus connections also for session bus

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/usermetricsservice/DBusDataSet.cpp'
2--- src/usermetricsservice/DBusDataSet.cpp 2013-10-22 08:53:23 +0000
3+++ src/usermetricsservice/DBusDataSet.cpp 2015-04-27 11:46:50 +0000
4@@ -49,7 +49,8 @@
5 }
6
7 DBusDataSet::~DBusDataSet() {
8- QDBusConnection connection(QDBusConnection::sessionBus());
9+ QDBusConnection connection(QDBusConnection::connectToBus(
10+ QDBusConnection::SessionBus, "usermetrics-sessionbus_1"));
11 connection.unregisterObject(m_path);
12 }
13
14
15=== modified file 'src/usermetricsservice/DBusDataSource.cpp'
16--- src/usermetricsservice/DBusDataSource.cpp 2015-01-29 12:37:39 +0000
17+++ src/usermetricsservice/DBusDataSource.cpp 2015-04-27 11:46:50 +0000
18@@ -44,7 +44,8 @@
19 }
20
21 DBusDataSource::~DBusDataSource() {
22- QDBusConnection connection(QDBusConnection::sessionBus());
23+ QDBusConnection connection(QDBusConnection::connectToBus(
24+ QDBusConnection::SessionBus, "usermetrics-sessionbus_2"));
25 connection.unregisterObject(m_path);
26 }
27
28
29=== modified file 'src/usermetricsservice/DBusUserData.cpp'
30--- src/usermetricsservice/DBusUserData.cpp 2014-01-20 10:33:36 +0000
31+++ src/usermetricsservice/DBusUserData.cpp 2015-04-27 11:46:50 +0000
32@@ -56,7 +56,8 @@
33 }
34
35 DBusUserData::~DBusUserData() {
36- QDBusConnection connection(QDBusConnection::sessionBus());
37+ QDBusConnection connection(QDBusConnection::connectToBus(
38+ QDBusConnection::SessionBus, "usermetrics-sessionbus_3"));
39 connection.unregisterObject(m_path);
40 }
41

Subscribers

People subscribed via source and target branches

to all changes: