Merge lp:~timo-jyrinki/kubuntu-packaging/qtdeclarative-opensource-src_fix_rfc2822_again into lp:~kubuntu-packagers/kubuntu-packaging/qtdeclarative-opensource-src

Proposed by Timo Jyrinki
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 162
Merged at revision: 161
Proposed branch: lp:~timo-jyrinki/kubuntu-packaging/qtdeclarative-opensource-src_fix_rfc2822_again
Merge into: lp:~kubuntu-packagers/kubuntu-packaging/qtdeclarative-opensource-src
Diff against target: 56 lines (+36/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/Support-RFC2822Date-date-format-similar-to-V8.patch (+28/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~timo-jyrinki/kubuntu-packaging/qtdeclarative-opensource-src_fix_rfc2822_again
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Kubuntu Packagers Pending
Review via email: mp+225784@code.launchpad.net

Commit message

* debian/patches/Support-RFC2822Date-date-format-similar-to-V8.patch
  - Support RFC 2822 format (LP: #1298978)

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Cleaned up headers from lp:~bzoltan/kubuntu-packaging/Revert_the_Support-RFC2822Date-date-format-similar-to-V8 + Zoltan's PPA upload, otherwise the same.

In CI Train.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-07-01 13:58:25 +0000
3+++ debian/changelog 2014-07-07 08:53:22 +0000
4@@ -1,3 +1,10 @@
5+qtdeclarative-opensource-src (5.3.0-3ubuntu7) utopic; urgency=medium
6+
7+ * debian/patches/Support-RFC2822Date-date-format-similar-to-V8.patch
8+ - Support RFC 2822 format (LP: #1298978)
9+
10+ -- Zoltán Balogh <zoltan@bakter.hu> Thu, 03 Jul 2014 15:52:17 +0300
11+
12 qtdeclarative-opensource-src (5.3.0-3ubuntu6) utopic; urgency=medium
13
14 * QQMLObjectCreator: Pass down parent to subCreator
15
16=== added file 'debian/patches/Support-RFC2822Date-date-format-similar-to-V8.patch'
17--- debian/patches/Support-RFC2822Date-date-format-similar-to-V8.patch 1970-01-01 00:00:00 +0000
18+++ debian/patches/Support-RFC2822Date-date-format-similar-to-V8.patch 2014-07-07 08:53:22 +0000
19@@ -0,0 +1,28 @@
20+Description: Support RFC 2822 datetime format
21+ Currently a date like "Wed, 18 Sep 2013 07:00:51 -0700" cannot be parsed.
22+ However, this used to work in Qt 5.0.2. This commit adds a check for
23+ Qt::RFC2822Date format after the ISODate check but before the manually
24+ defined QStringLiteral formats.
25+ .
26+ Note: upstream believed this bug is fixed in Qt 5.3, but it has been now
27+ tested not to be the case with both Debian's Qt 5.3.1 and Ubuntu's Qt 5.3.0
28+Author: Zoltán Balogh <zoltan@bakter.hu>
29+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1298978
30+Subject: [PATCH] Support RFC2822Date date format similar to V8.
31+Origin: upstream
32+Bug: https://bugreports.qt-project.org/browse/QTBUG-38011
33+Bug-Ubuntu: https://bugs.launchpad.net/bugs/1298978
34+Forwarded: https://bugreports.qt-project.org/browse/QTBUG-38011
35+Last-Update: 2014-07-07
36+
37+--- qtdeclarative-opensource-src-5.3.0.orig/src/qml/jsruntime/qv4dateobject.cpp
38++++ qtdeclarative-opensource-src-5.3.0/src/qml/jsruntime/qv4dateobject.cpp
39+@@ -488,6 +488,8 @@ static inline double ParseString(const Q
40+ QDateTime dt = QDateTime::fromString(s, Qt::TextDate);
41+ if (!dt.isValid())
42+ dt = QDateTime::fromString(s, Qt::ISODate);
43++ if (!dt.isValid())
44++ dt = QDateTime::fromString(s, Qt::RFC2822Date);
45+ if (!dt.isValid()) {
46+ QStringList formats;
47+ formats << QStringLiteral("M/d/yyyy")
48
49=== modified file 'debian/patches/series'
50--- debian/patches/series 2014-07-01 13:58:25 +0000
51+++ debian/patches/series 2014-07-07 08:53:22 +0000
52@@ -7,3 +7,4 @@
53 fix_qqmlobjectcreator.patch
54 Implement-proper-support-for-layoutChange-in-QQmlDel.patch
55 parenttosubcreator_qqmlobjectcreator.patch
56+Support-RFC2822Date-date-format-similar-to-V8.patch

Subscribers

People subscribed via source and target branches