Dropping Letters

Merge lp:~timo-jyrinki/dropping-letters/drop_audiorole_usage into lp:dropping-letters

  1. drop_audiorole_usage
  2. Merge into trunk
Proposed by Timo Jyrinki on 2015-10-21
Status: Merged
Approved by: Timo Jyrinki on 2015-11-23
Approved revision: 69
Merged at revision: 69
Proposed branch: lp:~timo-jyrinki/dropping-letters/drop_audiorole_usage
Merge into: lp:dropping-letters
Diff against target: 33 lines (+0/-4)
1 file modified
dropping-letters.qml (+0/-4)
To merge this branch: bzr merge lp:~timo-jyrinki/dropping-letters/drop_audiorole_usage
Reviewer Review Type Date Requested Status
Jenkins Bot continuous-integration Needs Fixing on 2015-11-10
Ubuntu Phone Apps Jenkins Bot continuous-integration Needs Fixing on 2015-10-28
Jim Hodapp (community) code Approve on 2015-10-21
Dropping Letters developers 2015-10-21 Pending
Review via email: mp+275150@code.launchpad.net

Commit Message

Drop audioRole usage as it shouldn't be used in this use case

To post a comment you must log in.
Jim Hodapp (jhodapp) wrote :

Looks good to me.

review: Approve (code)
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
https://core-apps-jenkins.ubuntu.com/job/dropping-letters-autolanding/1/
Executed test runs:
    None: https://core-apps-jenkins.ubuntu.com/job/generic-land-mp/379/console

review: Needs Fixing (continuous-integration)
Jenkins Bot (ubuntu-core-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'dropping-letters.qml'
2--- dropping-letters.qml 2014-09-26 22:56:07 +0000
3+++ dropping-letters.qml 2015-10-21 09:28:20 +0000
4@@ -331,21 +331,18 @@
5 id: click
6 source: "407__tictacshutup__click-1-off-click.ogg"
7 autoLoad: volume.supportsMedia
8- audioRole: MediaPlayer.alert
9 }
10
11 Audio {
12 id: success
13 source: "80921__justinbw__buttonchime02up.ogg"
14 autoLoad: volume.supportsMedia
15- audioRole: MediaPlayer.alert
16 }
17
18 Audio {
19 id: failure
20 source: "106727__kantouth__cartoon-bing-low.ogg"
21 autoLoad: volume.supportsMedia
22- audioRole: MediaPlayer.alert
23 }
24
25 Audio {
26@@ -355,7 +352,6 @@
27 onStopped: {
28 flipable.flipped = false
29 }
30- audioRole: MediaPlayer.alert
31 }
32
33 Rectangle {

Subscribers

People subscribed via source and target branches