Merge lp:~timo-jyrinki/autopilot/ap1.5_dbus_search_no_seen_connections into lp:autopilot/1.5

[Timo Jyrinki]

Do not store seen_connections

Paths can appear later than the bus has been created, so storing them to ignore them in the next loop can
make it ignore a bus that did not have the match but now does

https://code.launchpad.net/~aacid/autopilot/dbus_search_no_seen_connections/+merge/254109 from Albert but against a branch that could be released.

[Albert Astals Cid (aacid)]

review: Abstain

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:509
http://jenkins.qa.ubuntu.com/job/autopilot-1.5-ci/20/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-vivid-amd64-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-vivid-amd64-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-vivid-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-vivid-armhf-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-vivid-i386-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/autopilot-1.5-vivid-i386-ci/6/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-vivid-touch/1981
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid-autopilot/142
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-vivid-mako/1746
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1979
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-armhf/1979/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/19180
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid-autopilot/144
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/896
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/896/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/autopilot-1.5-ci/20/rebuild

review: Approve (continuous-integration)

[Christopher Lee (veebers)]

Rejected as this MP isn't needed. Due to the slightly obscure way that autopilot trunk is released (i.e. merged into this one) the code is merged into lp:autopilot then at landing time merged into lp:autopilot/1.5

Unmerged revisions

509. By Albert Astals Cid on 2015-03-26

Do not store seen_connections

Paths can appear later than the bus has been created, so storing them to ignore them in the next loop can
make it ignore a bus that did not have the match but now does

=== modified file 'autopilot/introspection/_search.py'
--- autopilot/introspection/_search.py	2014-07-31 20:02:49 +0000
+++ autopilot/introspection/_search.py	2015-03-26 06:35:45 +0000
@@ -307,17 +307,13 @@
         while we're searching for it.
 
     """
-    seen_connections = []
-
     for _ in Timeout.default():
         _get_child_pids.reset_cache()
         _raise_if_process_has_exited(process)
 
         connections = _get_buses_unchecked_connection_names(
-            bus,
-            seen_connections
+            bus
         )
-        seen_connections.extend(connections)
 
         valid_connections = [
             c for c