Merge lp:~tigrangab/slingshot/rtl_fix into lp:~elementary-pantheon/slingshot/trunk
Proposed by
Tigran Gabrielyan
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Cody Garver | ||||
Proposed branch: | lp:~tigrangab/slingshot/rtl_fix | ||||
Merge into: | lp:~elementary-pantheon/slingshot/trunk | ||||
Diff against target: |
239 lines (+76/-51) 1 file modified
src/SlingshotView.vala (+76/-51) |
||||
To merge this branch: | bzr merge lp:~tigrangab/slingshot/rtl_fix | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
David Gomes (community) | Needs Fixing | ||
Review via email: mp+184029@code.launchpad.net |
Description of the change
Needs this granite branch to work correctly: https:/
To post a comment you must log in.
Unmerged revisions
- 381. By Tigran Gabrielyan
-
Fix RTL key navigation
- 380. By Tigran Gabrielyan
-
Fix keyboard and scroll navigation for RTL
- 379. By Tigran Gabrielyan
-
Show slingshot on right side of screen if language is RTL
I'm afraid that's really not enoguh, RTL goes way deeper than that, whereas your patch could solve the positioning problem, things like page-scrolling and keyboard shortcuts are still hardcoded as in a LTR prospective.