Merge lp:~tigrangab/plank/focused_window_font into lp:plank

[Tigran Gabrielyan]

When there are multiple windows opened of the same application, make the focused windows menu entry bold to know which one is focused.

[Robert Dyer (psybers)]

I wonder if maybe it makes more sense to just remove the entry from the list...

I'm not a fan of the menu items changing often (based on context). Perhaps we could leave it and make it disabled?

Again, I'm asking for input from Dan here.

review: Needs Information

[Tigran Gabrielyan (tigrangab)]

The change for that is trivial, so just let me know the design choice, and I will fix it.

[Rico Tzschichholz (ricotz)]

I like it as it looks now. Hiding items for actual visible windows is not a good idea.

Two notes:
* I would only add the focus action for non-active windows.
* explicit use of copy "var font_description = window_item.get_pango_context ().get_font_description ().copy ();"

[Danielle Foré (danrabbit)]

I agree with Robert that insensitive makes more sense than bold.

In the case of switching windows, I think you're precisely not looking for the active window. So making it stand out by making it bold I think draws your attention in the opposite of the desired direction.

I also agree with Rico that removing the item doesn't sound right.

[Rico Tzschichholz (ricotz)]

OK, making them only insensitive seems fine then.

review: Needs Fixing

[lp:~tigrangab/plank/focused_window_font]

944. By Tigran Gabrielyan on 2014-01-21

Make active window's menu item insensitive

[Tigran Gabrielyan (tigrangab)]

I changed it to make it insensitive, here's how it looks: http://i.imgur.com/amDQcuW.png

[Rico Tzschichholz (ricotz)]

review: Approve

=== modified file 'lib/Items/ApplicationDockItem.vala'
--- lib/Items/ApplicationDockItem.vala	2014-01-21 12:42:02 +0000
+++ lib/Items/ApplicationDockItem.vala	2014-01-21 19:04:18 +0000
@@ -433,6 +433,8 @@
 					else 
 						window_item = create_menu_item (window.get_name (), Icon, true);
 					window_item.activate.connect (() => WindowControl.focus_window (window));
+					if (window.is_active ())
+						window_item.set_sensitive (false);
 					items.add (window_item);
 				}
 			}