Gala

Merge lp:~tigrangab/gala/fixes into lp:gala

  1. fixes
  2. Merge into trunk
Proposed by Tigran Gabrielyan
Status: Merged
Merged at revision: 403
Proposed branch: lp:~tigrangab/gala/fixes
Merge into: lp:gala
Diff against target: 21 lines (+3/-3)
1 file modified
src/Widgets/WindowClone.vala (+3/-3)
To merge this branch: bzr merge lp:~tigrangab/gala/fixes
Reviewer Review Type Date Requested Status
Tom Beckmann Approve
Review via email: mp+229167@code.launchpad.net

Description of the change

Adjusted the position of the close icon, it was off and would be hidden by the window to the right of it: https://i.imgur.com/kgCAbvc.png (notice how the close icon for sublime is behind the mysql workbench window)

After the adjustment: https://i.imgur.com/9SYYYUV.png

To post a comment you must log in.
Revision history for this message
Tom Beckmann (tombeckmann) wrote :

Looks good, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/WindowClone.vala'
2--- src/Widgets/WindowClone.vala 2014-07-17 12:16:01 +0000
3+++ src/Widgets/WindowClone.vala 2014-08-01 05:58:22 +0000
4@@ -399,14 +399,14 @@
5 close_button.save_easing_state ();
6 close_button.set_easing_duration (0);
7
8- close_button.y = -close_button.height * 0.25f;
9+ close_button.y = -close_button.height * 0.33f;
10
11 switch (pos) {
12 case Granite.CloseButtonPosition.RIGHT:
13- close_button.x = dest_width + close_button.width * 0.25f;
14+ close_button.x = dest_width - close_button.width * 0.5f;
15 break;
16 case Granite.CloseButtonPosition.LEFT:
17- close_button.x = -close_button.width * 0.25f;
18+ close_button.x = -close_button.width * 0.5f;
19 break;
20 }
21 close_button.restore_easing_state ();

Subscribers

People subscribed via source and target branches