Hey,
this is great work, thank you Tiago. It requires some fixes though:
- first, your patch to dee-qt may need fixing. I'm blaming it for these problems:
- on first run, all the icons were ? icons with no text.
- bug I can reproduce:
1. I hope dash. I search for something, I get correct results
2. if I empty search box, everything is still good
3. I switch to applications lens, everything good
4. I switch back to home lens, I get many ? icons everywhere with no text (just like first run)
But the bug may be here. I've not tried to dig yet.
Here's screengrab to show you: https://imgur.com/wTMaN
- possibly as a consequence, I get these unity-2d errors when viewing Home lens
[WARNING] shell/dash/RendererGrid.qml:92: ReferenceError: Can't find variable: column_0
[WARNING] shell/dash/RendererGrid.qml:92: ReferenceError: Can't find variable: display
[WARNING] shell/dash/LensView.qml:87: Unable to assign [undefined] to QString iconHint
[WARNING] shell/dash/LensView.qml:88: Unable to assign [undefined] to QString rendererName
[WARNING] shell/dash/LensView.qml:86: Unable to assign [undefined] to QString name
<repeated many times>
[WARNING] shell/dash/RendererGrid.qml:92: ReferenceError: Can't find variable: column_0
<repeated many times>
But your code looks clean, nothing obvious appears wrong to me.
Hey, /imgur. com/wTMaN
this is great work, thank you Tiago. It requires some fixes though:
- first, your patch to dee-qt may need fixing. I'm blaming it for these problems:
- on first run, all the icons were ? icons with no text.
- bug I can reproduce:
1. I hope dash. I search for something, I get correct results
2. if I empty search box, everything is still good
3. I switch to applications lens, everything good
4. I switch back to home lens, I get many ? icons everywhere with no text (just like first run)
But the bug may be here. I've not tried to dig yet.
Here's screengrab to show you: https:/
- possibly as a consequence, I get these unity-2d errors when viewing Home lens RendererGrid. qml:92: ReferenceError: Can't find variable: column_0 RendererGrid. qml:92: ReferenceError: Can't find variable: display
[WARNING] shell/dash/
[WARNING] shell/dash/
[WARNING] shell/dash/ LensView. qml:87: Unable to assign [undefined] to QString iconHint LensView. qml:88: Unable to assign [undefined] to QString rendererName LensView. qml:86: Unable to assign [undefined] to QString name
[WARNING] shell/dash/
[WARNING] shell/dash/
<repeated many times>
[WARNING] shell/dash/ RendererGrid. qml:92: ReferenceError: Can't find variable: column_0
<repeated many times>
But your code looks clean, nothing obvious appears wrong to me.