Merge lp:~tiagosh/unity-2d/fix-lensbar-arrow into lp:unity-2d

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gerry Boland
Approved revision: 917
Merged at revision: 939
Proposed branch: lp:~tiagosh/unity-2d/fix-lensbar-arrow
Merge into: lp:unity-2d
Diff against target: 16 lines (+2/-2)
1 file modified
shell/dash/LensButton.qml (+2/-2)
To merge this branch: bzr merge lp:~tiagosh/unity-2d/fix-lensbar-arrow
Reviewer Review Type Date Requested Status
Gerry Boland (community) Approve
Xi Zhu Pending
Review via email: mp+93063@code.launchpad.net

Description of the change

[dash] selected lens arrow must be displayed on top instead of bottom

To post a comment you must log in.
Revision history for this message
Gerry Boland (gerboland) wrote :

Can you please supply a screenshot so design can sign this off please?

Revision history for this message
Gerry Boland (gerboland) wrote :

Screenshots are available in the bug attached to this MR.

Revision history for this message
Xi Zhu (xi.zhu) wrote :

the screenshot looks good, apart from removing the glow! :)

Revision history for this message
Gerry Boland (gerboland) wrote :

Yes, glow will be removed in later MR. Thank you Xi! Approving!
-G

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/dash/LensButton.qml'
2--- shell/dash/LensButton.qml 2011-12-08 19:16:20 +0000
3+++ shell/dash/LensButton.qml 2012-02-14 20:12:17 +0000
4@@ -77,10 +77,10 @@
5 height: sourceSize.height
6 smooth: true
7 anchors.bottomMargin: (width-height)/2 /* Correct for rotation */
8- anchors.bottom: parent.bottom
9+ anchors.bottom: icon
10 anchors.horizontalCenter: parent.horizontalCenter
11
12- rotation: -90
13+ rotation: 90
14 visible: active
15 }
16 }

Subscribers

People subscribed via source and target branches