Merge lp:~tiagosh/unity-2d/fix-arrow-warning into lp:unity-2d

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 955
Merged at revision: 956
Proposed branch: lp:~tiagosh/unity-2d/fix-arrow-warning
Merge into: lp:unity-2d
Diff against target: 13 lines (+1/-2)
1 file modified
shell/dash/LensButton.qml (+1/-2)
To merge this branch: bzr merge lp:~tiagosh/unity-2d/fix-arrow-warning
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Review via email: mp+95944@code.launchpad.net

Description of the change

[dash] anchor the lens button arrow correctly in order to get rid of some warnings

To post a comment you must log in.
Revision history for this message
Albert Astals Cid (aacid) wrote :

Do we need
  anchors.bottomMargin
if we are not anchoring to the bottom any more?

review: Needs Fixing
955. By Tiago Salem Herrmann

remove unused margin

Revision history for this message
Tiago Salem Herrmann (tiagosh) wrote :

fixed

Revision history for this message
Albert Astals Cid (aacid) wrote :

Looks good, warning is gone, works fine :-)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'shell/dash/LensButton.qml'
2--- shell/dash/LensButton.qml 2012-02-27 21:28:23 +0000
3+++ shell/dash/LensButton.qml 2012-03-06 14:25:24 +0000
4@@ -68,8 +68,7 @@
5 width: sourceSize.width
6 height: sourceSize.height
7 smooth: true
8- anchors.bottomMargin: (width-height)/2 /* Correct for rotation */
9- anchors.bottom: icon
10+ anchors.top: parent.top
11 anchors.horizontalCenter: parent.horizontalCenter
12
13 rotation: 90

Subscribers

People subscribed via source and target branches