Merge lp:~tiagosh/unity-2d/bugfix-893061 into lp:unity-2d

[Tiago Salem Herrmann]

[dash] Remove underline from "Filter results" when it is highlighted

The width of "Filter Results" string is being changed from 99 to 100 everytime it gets underlined. (the blur effect does not change the width though)
So here is a hack to prevent the Text element to be resized whenever the font is changed.

[Gerry Boland (gerboland)]

I think that underline is strange. Could we get Design to confirm that it is correct?

[Gerry Boland (gerboland)]

Have attached Ayatana Design to bug, waiting on clarification from them.

review: Needs Information

[Gerry Boland (gerboland)]

The underline is incorrect. Removing it should fix this issue, and there'll be need for this workaround.

review: Needs Fixing

[lp:~tiagosh/unity-2d/bugfix-893061]

794. By Tiago Salem Herrmann on 2011-12-21

rebase

795. By Tiago Salem Herrmann on 2011-12-21

[places] remove underline from "Filter Results" when highlighted

[Tiago Salem Herrmann (tiagosh)]

done. rebased and removed the underline.

[Gerry Boland (gerboland)]

Thanks Tiago!

Can you please do the following:
Add a quick Manual Test to check this in tests/manual-tests/places.txt

[lp:~tiagosh/unity-2d/bugfix-893061]

796. By Tiago Salem Herrmann on 2011-12-21

[places] add manual test

797. By Tiago Salem Herrmann on 2011-12-21

[places] add lp bug number

[Tiago Salem Herrmann (tiagosh)]

> Thanks Tiago!
>
> Can you please do the following:
> Add a quick Manual Test to check this in tests/manual-tests/places.txt

done! thanks.

[Gerry Boland (gerboland)]

Perfect, thank you!

review: Approve

=== modified file 'places/FilterPane.qml'
--- places/FilterPane.qml	2011-12-19 10:44:26 +0000
+++ places/FilterPane.qml	2011-12-21 15:35:33 +0000
@@ -69,7 +69,6 @@
             text: u2d.tr("Filter results")
             font.bold: true
             fontSize: "large"
-            font.underline: parent.state == "selected"
 
             anchors.verticalCenter: parent.verticalCenter
             anchors.right: arrow.left

=== modified file 'tests/manual-tests/places.txt'
--- tests/manual-tests/places.txt	2011-12-07 15:01:18 +0000
+++ tests/manual-tests/places.txt	2011-12-21 15:35:33 +0000
@@ -11,3 +11,9 @@
 --> Dash opens and "Run a command" is shown in the search field - (lp:883392)
 
 ----
+
+ * Hit super key to Open Dash, select the file lens and press right arrow key
+
+--> The text "Filter results" gets highlighted and no underline is shown. (lp:893061)
+
+----