Merge lp:~tiagosh/ubuntu/wily/telepathy-mission-control-5/allow-getprop-execution into lp:ubuntu/wily/telepathy-mission-control-5

Proposed by Tiago Salem Herrmann on 2015-05-14
Status: Needs review
Proposed branch: lp:~tiagosh/ubuntu/wily/telepathy-mission-control-5/allow-getprop-execution
Merge into: lp:ubuntu/wily/telepathy-mission-control-5
Diff against target: 15 lines (+5/-0)
1 file modified
debian/apparmor-profile (+5/-0)
To merge this branch: bzr merge lp:~tiagosh/ubuntu/wily/telepathy-mission-control-5/allow-getprop-execution
Reviewer Review Type Date Requested Status
Jamie Strandboge 2015-05-14 Approve on 2015-05-18
Review via email: mp+259174@code.launchpad.net

Commit Message

Allow getprop execution by mission-control and its plugins.

Description of the Change

Allow getprop execution by mission-control and its plugins.

This is required by the following MR:
https://code.launchpad.net/~tiagosh/telepathy-ofono/add-ril-mc-plugin/+merge/259173

To post a comment you must log in.
Jamie Strandboge (jdstrand) wrote :

This was previously discussed with the security. LGTM

review: Approve

Unmerged revisions

83. By Tiago Salem Herrmann on 2015-05-14

Allow getprop execution by mission-control and its plugins

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/apparmor-profile'
2--- debian/apparmor-profile 2014-09-02 21:06:42 +0000
3+++ debian/apparmor-profile 2015-05-14 21:29:20 +0000
4@@ -59,6 +59,11 @@
5 /usr/share/accounts/services/ r,
6 /usr/share/accounts/services/** r,
7
8+ # for mcp-account-manager-ofono.so loaded dynamically by mission-control
9+ owner @{PROC}/[0-9]*/fd/ r,
10+ /usr/bin/getprop ix,
11+ /{,android/}system/build.prop r,
12+
13 # Site-specific additions and overrides. See local/README for details.
14 # Please note that accesses in local/usr.lib.telepathy are also applied to
15 # /usr/lib/telepathy/telepathy-*.

Subscribers

People subscribed via source and target branches