telephony-service

Merge lp:~tiagosh/telephony-service/no_translated_app_id into lp:telephony-service

  1. no_translated_app_id
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Needs review
Proposed branch: lp:~tiagosh/telephony-service/no_translated_app_id
Merge into: lp:telephony-service
Diff against target: 24 lines (+2/-2)
2 files modified
approver/main.cpp (+1/-1)
indicator/main.cpp (+1/-1)
To merge this branch: bzr merge lp:~tiagosh/telephony-service/no_translated_app_id
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
PS Jenkins bot continuous-integration Approve
Ubuntu Phablet Team Pending
Review via email: mp+282176@code.launchpad.net

Commit message

Do not use translated strings for the app_id.

Description of the change

Do not use translated strings for the app_id.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1159
http://jenkins.qa.ubuntu.com/job/telephony-service-ci/661/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-amd64-ci/333
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/329
        deb: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-armhf-ci/329/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telephony-service-vivid-i386-ci/329

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telephony-service-ci/661/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1159
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/5/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/524/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/524
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/516
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/516
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/511/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/511/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/511/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/511/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/511/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/511/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/5/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:1159
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/7/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/527/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/527
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/518
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/518
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/514/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/514/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/514
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/514/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/514
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/514/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/514
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/514/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/514
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/514/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telephony-service-ci/7/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

1159. By Tiago Salem Herrmann

Do not use translated strings for the app_id

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'approver/main.cpp'
2--- approver/main.cpp 2015-01-12 20:43:06 +0000
3+++ approver/main.cpp 2016-01-11 14:28:36 +0000
4@@ -43,7 +43,7 @@
5 C::bindtextdomain( "telephony-service", "/usr/share/locale" );
6 C::textdomain("telephony-service");
7
8- notify_init(C::gettext("Telephony Service Approver"));
9+ notify_init("telephony-service-approver");
10
11 Tp::registerTypes();
12
13
14=== modified file 'indicator/main.cpp'
15--- indicator/main.cpp 2015-06-24 18:23:08 +0000
16+++ indicator/main.cpp 2016-01-11 14:28:36 +0000
17@@ -49,7 +49,7 @@
18 C::bindtextdomain( "telephony-service", "/usr/share/locale" );
19 C::textdomain("telephony-service");
20
21- notify_init(C::gettext("Telephony Service Indicator"));
22+ notify_init("telephony-service-indicator");
23
24 Tp::registerTypes();
25

Subscribers

People subscribed via source and target branches