Merge lp:~tiagosh/telephony-service/launch-indicator into lp:telephony-service

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 792
Merged at revision: 790
Proposed branch: lp:~tiagosh/telephony-service/launch-indicator
Merge into: lp:telephony-service
Prerequisite: lp:~tiagosh/telephony-service/fix-tests
Diff against target: 23 lines (+10/-0)
2 files modified
debian/telephony-service.install (+1/-0)
upstart/telephony-service-indicator.conf (+9/-0)
To merge this branch: bzr merge lp:~tiagosh/telephony-service/launch-indicator
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+212929@code.launchpad.net

This proposal supersedes a proposal from 2014-03-24.

Commit message

Add upstart job to launch telephony-service indicator at startup.

Description of the change

Add upstart job to launch telephony-service indicator at startup.

--------------------
Are there any related MPs required for this MP to build/function as expected? Please list.
https://code.launchpad.net/~tiagosh/telephony-service/fix-tests/+merge/212932

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/telephony-service) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you subscribe a core-dev to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote : Posted in a previous version of this proposal
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
792. By Tiago Salem Herrmann

merge test fixes

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/telephony-service.install'
2--- debian/telephony-service.install 2013-12-21 23:44:41 +0000
3+++ debian/telephony-service.install 2014-03-27 16:37:53 +0000
4@@ -15,3 +15,4 @@
5 usr/share/telepathy/clients/TelephonyService*.client
6 usr/share/telephony-service/assets/*
7 var/lib/polkit-1/localauthority/10-vendor.d/*TelephonyService*.pkla
8+upstart/telephony-service-indicator.conf /usr/share/upstart/sessions
9
10=== added directory 'upstart'
11=== added file 'upstart/telephony-service-indicator.conf'
12--- upstart/telephony-service-indicator.conf 1970-01-01 00:00:00 +0000
13+++ upstart/telephony-service-indicator.conf 2014-03-27 16:37:53 +0000
14@@ -0,0 +1,9 @@
15+description "telephony-service-indicator"
16+author "Tiago Salem Herrmann <tiago.herrmann@canonical.com>"
17+
18+start on started unity8
19+stop on session-end
20+
21+respawn
22+
23+exec /usr/bin/telephony-service-indicator

Subscribers

People subscribed via source and target branches