Merge lp:~tiagosh/telephony-service/fix-1453004 into lp:telephony-service/rtm-15.04
Status: | Merged |
---|---|
Approved by: | Gustavo Pichorim Boiko |
Approved revision: | 1095 |
Merged at revision: | 1095 |
Proposed branch: | lp:~tiagosh/telephony-service/fix-1453004 |
Merge into: | lp:telephony-service/rtm-15.04 |
Diff against target: |
189 lines (+98/-6) 5 files modified
approver/approver.cpp (+3/-0) cmake/modules/GenerateTest.cmake (+1/-0) indicator/ussdindicator.cpp (+13/-6) tests/common/CMakeLists.txt (+3/-0) tests/common/NotificationsMock.cpp (+78/-0) |
To merge this branch: | bzr merge lp:~tiagosh/telephony-service/fix-1453004 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Pichorim Boiko (community) | Approve | ||
Review via email:
|
Commit message
- Do not let USSD and incoming call snap decisions timeout.
- Initialize m_notificationId with -1, as 0 is a valid id.
- Do not call CloseNotification() when notificationClo
Description of the change
- Do not let USSD and incoming call snap decisions timeout.
- Initialize m_notificationId with -1, as 0 is a valid id.
- Do not call CloseNotification() when notificationClo
--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No
Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes
Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes
Did you successfully run all tests found in your component's Test Plan (https:/
Yes
If you changed the UI, was the change specified/approved by design?
N/A
If you changed UI labels, did you update the pot file?
N/A
If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A
Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes
Did CI run pass? If not, please explain why.
Yes, on a previously submitted MP against trunk.
Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes