Merge lp:~tiagosh/telephony-service/clear-read-messages into lp:telephony-service

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 839
Merged at revision: 840
Proposed branch: lp:~tiagosh/telephony-service/clear-read-messages
Merge into: lp:telephony-service
Diff against target: 13 lines (+2/-1)
1 file modified
indicator/textchannelobserver.cpp (+2/-1)
To merge this branch: bzr merge lp:~tiagosh/telephony-service/clear-read-messages
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+225905@code.launchpad.net

Commit message

Fix message token to properly remove read messages from the messaging menu.

Description of the change

Fix message token to properly remove read messages from the messaging menu.

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/telephony-service) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'indicator/textchannelobserver.cpp'
2--- indicator/textchannelobserver.cpp 2014-07-03 03:24:43 +0000
3+++ indicator/textchannelobserver.cpp 2014-07-07 22:10:56 +0000
4@@ -373,7 +373,8 @@
5
6 void TextChannelObserver::onPendingMessageRemoved(const Tp::ReceivedMessage &message)
7 {
8- MessagingMenu::instance()->removeMessage(message.messageToken());
9+ QByteArray token(message.messageToken().toUtf8());
10+ MessagingMenu::instance()->removeMessage(token.toHex());
11 }
12
13 void TextChannelObserver::onReplyReceived(const QString &phoneNumber, const QString &reply)

Subscribers

People subscribed via source and target branches