Merge lp:~tiagosh/telepathy-ofono/speaker-mode-asynchronous into lp:telepathy-ofono

[Tiago Salem Herrmann]

Update audio route asynchronously when enabling/disabling speaker mode.

Update audio route asynchronously.
On some devices (nexus 4) switching from/to speaker mode can take a while, so we need to avoid updating the audio route immediately.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:65
http://jenkins.qa.ubuntu.com/job/telepathy-ofono-ci/70/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-trusty-amd64-ci/49
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-trusty-armhf-ci/49
        deb: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-trusty-armhf-ci/49/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-trusty-i386-ci/48

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telepathy-ofono-ci/70/rebuild

review: Approve (continuous-integration)

[Tiago Salem Herrmann (tiagosh)]

Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/telepathy-ofono) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
No changes

If you changed the packaging (debian), did you subscribe a core-dev to this MP?
No changes

[Gustavo Pichorim Boiko (boiko)]

Did you perform an exploratory manual test run of the code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/telepathy-ofono) on device or emulator?
Yes

Did CI run pass? If not, please explain why.
Yes

Have you checked that submitter has accurately filled out the submitter checklist and has taken no shortcut?
Yes

Code looks good and fixes the problem.

review: Approve

=== modified file 'connection.cpp'
--- connection.cpp	2014-02-13 13:00:30 +0000
+++ connection.cpp	2014-02-20 19:08:49 +0000
@@ -837,7 +837,7 @@
 {
     if (mSpeakerMode != active) {
         mSpeakerMode = active;
-        updateAudioRoute();
+        QMetaObject::invokeMethod(this, "updateAudioRoute", Qt::QueuedConnection);
         Q_EMIT speakerModeChanged(active);
     }
 }