telepathy-ofono

Merge lp:~tiagosh/telepathy-ofono/rename-mms-flag into lp:telepathy-ofono

  1. rename-mms-flag
  2. Merge into trunk
Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 163
Merged at revision: 169
Proposed branch: lp:~tiagosh/telepathy-ofono/rename-mms-flag
Merge into: lp:telepathy-ofono
Diff against target: 21 lines (+2/-2)
1 file modified
ofonotextchannel.cpp (+2/-2)
To merge this branch: bzr merge lp:~tiagosh/telepathy-ofono/rename-mms-flag
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+267589@code.launchpad.net

Commit message

Rename mms flag set by telephony-service.

Description of the change

Rename mms flag set by telephony-service.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:159
http://jenkins.qa.ubuntu.com/job/telepathy-ofono-ci/194/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-amd64-ci/55
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/52
        deb: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/52/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-i386-ci/52

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telepathy-ofono-ci/194/rebuild

review: Approve (continuous-integration)
lp:~tiagosh/telepathy-ofono/rename-mms-flag updated
160. By Tiago Salem Herrmann

rename flag in another place

161. By Tiago Salem Herrmann

merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:161
http://jenkins.qa.ubuntu.com/job/telepathy-ofono-ci/195/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-amd64-ci/56
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/53
        deb: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/53/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-i386-ci/53

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telepathy-ofono-ci/195/rebuild

review: Approve (continuous-integration)
lp:~tiagosh/telepathy-ofono/rename-mms-flag updated
162. By Tiago Salem Herrmann

merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:162
http://jenkins.qa.ubuntu.com/job/telepathy-ofono-ci/201/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-amd64-ci/62
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/59
        deb: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/59/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-i386-ci/59

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telepathy-ofono-ci/201/rebuild

review: Approve (continuous-integration)
lp:~tiagosh/telepathy-ofono/rename-mms-flag updated
163. By Tiago Salem Herrmann

merge trunk

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:163
http://jenkins.qa.ubuntu.com/job/telepathy-ofono-ci/206/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-amd64-ci/67
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/64
        deb: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/64/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-i386-ci/64

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telepathy-ofono-ci/206/rebuild

review: Approve (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ofonotextchannel.cpp'
2--- ofonotextchannel.cpp 2015-05-18 13:30:00 +0000
3+++ ofonotextchannel.cpp 2015-11-05 13:37:03 +0000
4@@ -177,7 +177,7 @@
5 Tp::MessagePart body = message.at(1);
6 QString objpath;
7
8- bool mms = header["mms"].variant().toBool();
9+ bool mms = header["x-canonical-mms"].variant().toBool();
10
11 if (mms) {
12 // pop header out
13@@ -426,7 +426,7 @@
14 header["message-sender"] = QDBusVariant(handle);
15 header["message-received"] = QDBusVariant(QDateTime::currentDateTimeUtc().toTime_t());
16 header["message-type"] = QDBusVariant(Tp::DeliveryStatusDelivered);
17- header["mms"] = QDBusVariant(true);
18+ header["x-canonical-mms"] = QDBusVariant(true);
19 if (!subject.isEmpty())
20 {
21 header["subject"] = QDBusVariant(subject);

Subscribers

People subscribed via source and target branches