Code review comment for lp:~tiagosh/telepathy-ofono/no_route_change_on_disconnect

Revision history for this message
Tony Espy (awe) wrote :

Seems like a fair amount of duplicate code there... however I'll let it slide for now.

Also, is there really a case where call->state() will return an empty string?

I'll approve, but this code seems ripe for a code review post 13.10 ( especially once we start working on multi call support ).

review: Approve

« Back to merge proposal