Merge lp:~tiagosh/telepathy-ofono/missed-calls into lp:telepathy-ofono

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Michael Terry
Approved revision: 76
Merged at revision: 78
Proposed branch: lp:~tiagosh/telepathy-ofono/missed-calls
Merge into: lp:telepathy-ofono
Diff against target: 32 lines (+7/-0)
2 files modified
ofonocallchannel.cpp (+6/-0)
ofonocallchannel.h (+1/-0)
To merge this branch: bzr merge lp:~tiagosh/telepathy-ofono/missed-calls
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Michael Terry Approve
Review via email: mp+219027@code.launchpad.net

Commit message

Use DisconnectReason() from ofono to decide if the call was missed

Description of the change

Use DisconnectReason() from ofono to decide if the call was missed

-----Checklist-----
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/telepathy-ofono) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed the packaging (debian), did you subscribe a core-dev to this MP?
N/A

To post a comment you must log in.
Revision history for this message
Michael Terry (mterry) wrote :

Tested and works for me!

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ofonocallchannel.cpp'
2--- ofonocallchannel.cpp 2014-03-19 02:36:35 +0000
3+++ ofonocallchannel.cpp 2014-05-09 16:59:37 +0000
4@@ -142,10 +142,16 @@
5 QObject::connect(mConnection, SIGNAL(speakerModeChanged(bool)), mSpeakerIface.data(), SLOT(setSpeakerMode(bool)));
6 QObject::connect(mConnection->voiceCallManager(), SIGNAL(sendTonesComplete(bool)), SLOT(onDtmfComplete(bool)));
7 QObject::connect(this, SIGNAL(multipartyChanged(bool)), this, SLOT(onMultipartyChanged(bool)));
8+
9+ QObject::connect(this, SIGNAL(disconnectReason(const QString &)), this, SLOT(onDisconnectReason(const QString &)));
10
11 mSpeakerIface->setSpeakerMode(mConnection->speakerMode());
12 }
13
14+void oFonoCallChannel::onDisconnectReason(const QString &reason) {
15+ mRequestedHangup = reason == "local";
16+}
17+
18 void oFonoCallChannel::onMultipartyChanged(bool multiparty)
19 {
20 // if previous state was multparty then split
21
22=== modified file 'ofonocallchannel.h'
23--- ofonocallchannel.h 2014-02-14 17:48:08 +0000
24+++ ofonocallchannel.h 2014-05-09 16:59:37 +0000
25@@ -66,6 +66,7 @@
26
27 void onOfonoMuteChanged(bool mute);
28 void onMultipartyChanged(bool multiparty);
29+ void onDisconnectReason(const QString &reason);
30
31 private:
32 QString mObjPath;

Subscribers

People subscribed via source and target branches