Merge lp:~tiagosh/telepathy-ofono/fallback_a2dp into lp:telepathy-ofono

[Tiago Salem Herrmann]

Fallback to a2dp if no profile is set.

Fallback to a2dp if no profile is set.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:172
http://jenkins.qa.ubuntu.com/job/telepathy-ofono-ci/209/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-amd64-ci/70
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/67
        deb: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-armhf-ci/67/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/telepathy-ofono-vivid-i386-ci/67

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/telepathy-ofono-ci/209/rebuild

review: Approve (continuous-integration)

[system-apps-ci-bot (system-apps-ci-bot)]

FAILED: Continuous integration, rev:172
https://jenkins.canonical.com/system-apps/job/lp-telepathy-ofono-ci/3/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/574/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/574
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/555
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial/555
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=vivid+overlay/549/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=amd64,release=xenial/549/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/549
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=vivid+overlay/549/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/549
        deb: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=armhf,release=xenial/549/artifact/output/*zip*/output.zip
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=vivid+overlay/549/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-2-binpkg/arch=i386,release=xenial/549/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-telepathy-ofono-ci/3/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

172. By Tiago Salem Herrmann on 2015-11-27

Fallback to a2dp if no profile is set

171. By Tiago Salem Herrmann on 2015-11-24

Set bluetooth device when playing the ringtone

=== modified file 'qpulseaudioengine.cpp'
--- qpulseaudioengine.cpp	2015-11-10 07:49:07 +0000
+++ qpulseaudioengine.cpp	2015-11-27 15:57:17 +0000
@@ -113,6 +113,7 @@
     , m_voicecallprofile("")
     , m_bt_hsp("")
     , m_bt_hsp_a2dp("")
+    , m_default_bt_card_fallback("")
 
 {
     m_mainLoop = pa_threaded_mainloop_new();
@@ -658,14 +659,26 @@
 {
     qDebug("Notified about card (%s) add event from PulseAudio", info->name);
 
+    /* Check if it's indeed a BT device (with at least one hsp profile) */
+    pa_card_profile_info2 *hsp = NULL, *a2dp = NULL;
+    for (int i = 0; i < info->n_profiles; i++) {
+        if (!strcmp(info->profiles2[i]->name, PULSEAUDIO_PROFILE_HSP))
+            hsp = info->profiles2[i];
+        else if (!strcmp(info->profiles2[i]->name, PULSEAUDIO_PROFILE_A2DP) && 
+                  info->profiles2[i]->available != 0) {
+            qDebug("Found a2dp");
+            a2dp = info->profiles2[i];
+        }
+        qDebug("%s", info->profiles2[i]->name);
+    }
+
+    if ((!info->active_profile || !strcmp(info->active_profile->name, "off")) && a2dp) {
+        qDebug("No profile set");
+        m_default_bt_card_fallback = info->name;
+    }
+
     /* We only care about BT (HSP) devices, and if one is not already available */
     if ((m_callstatus != CallEnded) && ((m_bt_hsp == "") || (m_bt_hsp_a2dp == ""))) {
-        /* Check if it's indeed a BT device (with at least one hsp profile) */
-        pa_card_profile_info *hsp = NULL;
-        for (int i = 0; i < info->n_profiles; i++) {
-            if (!strcmp(info->profiles[i].name, PULSEAUDIO_PROFILE_HSP))
-                hsp = &info->profiles[i];
-        }
         if (hsp)
             m_handleevent = true;
     }
@@ -675,6 +688,25 @@
 {
     qDebug("Notified about card (%s) changes event from PulseAudio", info->name);
 
+    /* Check if it's indeed a BT device (with at least one hsp profile) */
+    pa_card_profile_info2 *hsp = NULL, *a2dp = NULL;
+    for (int i = 0; i < info->n_profiles; i++) {
+        if (!strcmp(info->profiles2[i]->name, PULSEAUDIO_PROFILE_HSP))
+            hsp = info->profiles2[i];
+        else if (!strcmp(info->profiles2[i]->name, PULSEAUDIO_PROFILE_A2DP) && 
+                  info->profiles2[i]->available != 0) {
+            qDebug("Found a2dp");
+            a2dp = info->profiles2[i];
+        }
+        qDebug("%s", info->profiles2[i]->name);
+    }
+
+    if ((!info->active_profile || !strcmp(info->active_profile->name, "off")) && a2dp) {
+        qDebug("No profile set");
+        m_default_bt_card_fallback = info->name;
+    }
+
+
     /* We only care if the card event for the voicecall capable card */
     if ((m_callstatus == CallActive) && (!strcmp(info->name, m_voicecallcard.c_str()))) {
         if (m_audiomode == AudioModeWiredHeadset) {
@@ -718,6 +750,15 @@
         o = pa_context_get_card_info_by_index(m_context, idx, plug_card_cb, this);
         if (!handleOperation(o, "pa_context_get_card_info_by_index"))
             return;
+
+        if (m_default_bt_card_fallback != "") {
+            o = pa_context_set_card_profile_by_name(m_context,
+                m_default_bt_card_fallback.c_str(), PULSEAUDIO_PROFILE_A2DP, success_cb, this);
+            if (!handleOperation(o, "pa_context_set_card_profile_by_name"))
+                return;
+            m_default_bt_card_fallback = "";
+        }
+
         if (m_handleevent) {
             qDebug("Adding new BT-HSP capable device");
             /* In case A2DP is available, switch to HSP */
@@ -730,6 +771,15 @@
         o = pa_context_get_card_info_by_index(m_context, idx, update_card_cb, this);
         if (!handleOperation(o, "pa_context_get_card_info_by_index"))
             return;
+
+        if (m_default_bt_card_fallback != "") {
+            o = pa_context_set_card_profile_by_name(m_context,
+                m_default_bt_card_fallback.c_str(), PULSEAUDIO_PROFILE_A2DP, success_cb, this);
+            if (!handleOperation(o, "pa_context_set_card_profile_by_name"))
+                return;
+            m_default_bt_card_fallback = "";
+        }
+
         if (m_handleevent) {
             /* In this case it means the handset state changed */
             qDebug("Notifying card changes for the voicecall capable card");

=== modified file 'qpulseaudioengine.h'
--- qpulseaudioengine.h	2015-11-27 15:57:17 +0000
+++ qpulseaudioengine.h	2015-11-27 15:57:17 +0000
@@ -95,6 +95,7 @@
     std::string m_nametoset, m_valuetoset;
     std::string m_defaultsink, m_defaultsource;
     std::string m_bt_hsp, m_bt_hsp_a2dp;
+    std::string m_default_bt_card_fallback;
     std::string m_voicecallcard, m_voicecallhighest, m_voicecallprofile;
 
     bool handleOperation(pa_operation *operation, const char *func_name);