Merge lp:~tiagosh/phone-app/phone-app-1185036 into lp:phone-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 662
Merged at revision: 661
Proposed branch: lp:~tiagosh/phone-app/phone-app-1185036
Merge into: lp:phone-app
Diff against target: 25 lines (+7/-0)
2 files modified
debian/changelog (+6/-0)
libphoneapp/contactentry.cpp (+1/-0)
To merge this branch: bzr merge lp:~tiagosh/phone-app/phone-app-1185036
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Approve
Review via email: mp+166400@code.launchpad.net

Commit message

Set favorite detail as modified when necessary

Description of the change

Set favorite detail as modified when necessary

To post a comment you must log in.
Revision history for this message
Bill Filler (bfiller) wrote :

change the series in the changelog to raring so it gets released

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
662. By Tiago Salem Herrmann

releasing version 0.59.12-0ubuntu3

Revision history for this message
Bill Filler (bfiller) wrote :

approved

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-05-29 18:07:26 +0000
3+++ debian/changelog 2013-05-29 23:19:27 +0000
4@@ -1,3 +1,9 @@
5+phone-app (0.59.12-0ubuntu3) raring; urgency=low
6+
7+ * Set favorite detail as modified when necessary (LP: #1185036).
8+
9+ -- Tiago Salem Herrmann <tiago.herrmann@canonical.com> Wed, 29 May 2013 19:14:23 -0300
10+
11 phone-app (0.59.12-0ubuntu2) raring; urgency=low
12
13 * Allow toggling favorite even when not editing a contact (LP: #1185064).
14
15=== modified file 'libphoneapp/contactentry.cpp'
16--- libphoneapp/contactentry.cpp 2013-05-29 13:24:09 +0000
17+++ libphoneapp/contactentry.cpp 2013-05-29 23:19:27 +0000
18@@ -69,6 +69,7 @@
19 QContactFavorite favorite = mContact.detail<QContactFavorite>();
20 favorite.setFavorite(value);
21 mContact.saveDetail(&favorite);
22+ setModified(true);
23 Q_EMIT changed(this);
24 }
25 }

Subscribers

People subscribed via source and target branches