Merge lp:~tiagosh/messaging-app/set_width_based_on_screen_size into lp:messaging-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 516
Merged at revision: 519
Proposed branch: lp:~tiagosh/messaging-app/set_width_based_on_screen_size
Merge into: lp:messaging-app
Diff against target: 19 lines (+2/-1)
1 file modified
src/qml/messaging-app.qml (+2/-1)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/set_width_based_on_screen_size
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+287074@code.launchpad.net

Commit message

Set width based on the screen size to avoid removing views from the stack when the app is resized.

Description of the change

Set width based on the screen size to avoid removing views from the stack when the app is resized.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/messaging-app.qml'
2--- src/qml/messaging-app.qml 2016-02-17 12:44:17 +0000
3+++ src/qml/messaging-app.qml 2016-02-24 18:25:48 +0000
4@@ -17,6 +17,7 @@
5 */
6
7 import QtQuick 2.2
8+import QtQuick.Window 2.2
9 import Qt.labs.settings 1.0
10 import Ubuntu.Components 1.3
11 import Ubuntu.Components.Popups 1.3
12@@ -146,7 +147,7 @@
13 }
14
15 automaticOrientation: true
16- width: units.gu(100)
17+ width: Screen.desktopAvailableWidth > units.gu(100) ? units.gu(100) : units.gu(40)
18 height: units.gu(71)
19 anchorToKeyboard: false
20

Subscribers

People subscribed via source and target branches