Merge lp:~tiagosh/messaging-app/fix_swipe-demo_text_position into lp:messaging-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 516
Merged at revision: 517
Proposed branch: lp:~tiagosh/messaging-app/fix_swipe-demo_text_position
Merge into: lp:messaging-app
Diff against target: 23 lines (+2/-3)
1 file modified
src/qml/SwipeItemDemo.qml (+2/-3)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/fix_swipe-demo_text_position
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Review via email: mp+286911@code.launchpad.net

Commit message

Makes text in the swipe demo use relative positioning instead of absolute.

Description of the change

This MR was created by Daniyaal Rasheed as a google code-in task, but it needs sync with trunk in order to get landed, so we are resubmitting the MR here. This is the original description:

"""
I've deleted the absolute height specification inside of the RowLayout so that the height of the message is entirely dependent on the height of the dragMessage. The "Got it" button is anchored to the bottom of the message because if it was anchored to the top, then it would jump around whenever the number of lines in the text increased or decreased. Then I changed the bottomMargin of the "Got it" button to be units.gu(21) instead of 19 because the message row layout used to have a height of 3 and the button was anchored to its top instead of bottom.
"""

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/SwipeItemDemo.qml'
2--- src/qml/SwipeItemDemo.qml 2015-11-03 13:16:43 +0000
3+++ src/qml/SwipeItemDemo.qml 2016-02-23 14:52:18 +0000
4@@ -69,9 +69,9 @@
5 objectName: "gotItButton"
6
7 anchors {
8- bottom: dragTitle.top
9+ bottom: dragTitle.bottom
10 horizontalCenter: parent.horizontalCenter
11- bottomMargin: units.gu(19)
12+ bottomMargin: units.gu(21)
13 }
14 width: units.gu(17)
15 strokeColor: UbuntuColors.green
16@@ -94,7 +94,6 @@
17 bottom: listItem.top
18 margins: units.gu(1)
19 }
20- height: units.gu(3)
21 spacing: units.gu(2)
22
23 Image {

Subscribers

People subscribed via source and target branches