Merge lp:~tiagosh/messaging-app/fix-image-preview into lp:messaging-app

Proposed by Tiago Salem Herrmann
Status: Merged
Merged at revision: 262
Proposed branch: lp:~tiagosh/messaging-app/fix-image-preview
Merge into: lp:messaging-app
Diff against target: 12 lines (+2/-0)
1 file modified
src/qml/Messages.qml (+2/-0)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/fix-image-preview
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+236918@code.launchpad.net

Commit message

Fix black image in the mms preview.

Description of the change

Fix black image in the mms preview.

--Checklist--
Are there any related MPs required for this MP to build/function as expected? Please list.
No

Is your branch in sync with latest trunk (e.g. bzr pull lp:trunk -> no changes)
Yes

Did you perform an exploratory manual test run of your code change and any related functionality on device or emulator?
Yes

Did you successfully run all tests found in your component's Test Plan (https://wiki.ubuntu.com/Process/Merges/TestPlan/messaging-app) on device or emulator?
Yes

If you changed the UI, was the change specified/approved by design?
N/A

If you changed UI labels, did you update the pot file?
N/A

If you changed the packaging (debian), did you add a core-dev as a reviewer to this MP?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/Messages.qml'
2--- src/qml/Messages.qml 2014-09-17 15:48:56 +0000
3+++ src/qml/Messages.qml 2014-10-02 15:32:28 +0000
4@@ -633,6 +633,8 @@
5 id: avatarImage
6 width: units.gu(8)
7 height: units.gu(8)
8+ sourceSize.height: height
9+ sourceSize.width: width
10 fillMode: Image.PreserveAspectCrop
11 source: filePath
12 asynchronous: true

Subscribers

People subscribed via source and target branches