Merge lp:~tiagosh/messaging-app/fix-highlight_current_item into lp:messaging-app

Proposed by Tiago Salem Herrmann
Status: Merged
Approved by: Bill Filler
Approved revision: 71
Merged at revision: 74
Proposed branch: lp:~tiagosh/messaging-app/fix-highlight_current_item
Merge into: lp:messaging-app
Diff against target: 40 lines (+9/-0)
1 file modified
src/qml/Messages.qml (+9/-0)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/fix-highlight_current_item
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+208871@code.launchpad.net

Commit message

set highlightFollowsCurrentItem to false to avoid unexpected behaviors with qt5.2

Description of the change

set highlightFollowsCurrentItem to false to avoid unexpected behaviors with qt5.2

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
71. By Tiago Salem Herrmann

scroll view when sending a new message.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

approved. works as expected under qt5.2 and has no effect on Qt5.0

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/Messages.qml'
2--- src/qml/Messages.qml 2014-02-18 21:12:44 +0000
3+++ src/qml/Messages.qml 2014-02-28 22:13:35 +0000
4@@ -38,6 +38,7 @@
5 // FIXME: MainView should provide if the view is in portait or landscape
6 property int orientationAngle: Screen.angleBetween(Screen.primaryOrientation, Screen.orientation)
7 property bool landscape: orientationAngle == 90 || orientationAngle == 270
8+ property bool pendingMessage: false
9 flickable: null
10 title: {
11 if (landscape) {
12@@ -392,6 +393,7 @@
13 listModel: threadId !== "" ? sortProxy : null
14 verticalLayoutDirection: ListView.BottomToTop
15 spacing: units.gu(2)
16+ highlightFollowsCurrentItem: false
17 listDelegate: MessageDelegate {
18 id: messageDelegate
19 incoming: senderId != "self"
20@@ -428,6 +430,12 @@
21 eventModel.removeEvent(event.accountId, event.threadId, event.eventId, event.type)
22 }
23 }
24+ onCountChanged: {
25+ if (messages.pendingMessage) {
26+ messageList.contentY = 0
27+ messages.pendingMessage = false
28+ }
29+ }
30 }
31
32 Item {
33@@ -501,6 +509,7 @@
34 HistoryThreadModel.MatchPhoneNumber,
35 true)
36 }
37+ messages.pendingMessage = true
38 chatManager.sendMessage(participants, textEntry.text)
39 textEntry.text = ""
40 }

Subscribers

People subscribed via source and target branches