Merge lp:~tiagosh/messaging-app/fix-1227356 into lp:messaging-app

Proposed by Tiago Salem Herrmann on 2013-09-23
Status: Merged
Approved by: Gustavo Pichorim Boiko on 2013-09-25
Approved revision: 37
Merged at revision: 38
Proposed branch: lp:~tiagosh/messaging-app/fix-1227356
Merge into: lp:messaging-app
Diff against target: 23 lines (+1/-1)
2 files modified
src/qml/Messages.qml (+1/-0)
tests/autopilot/messaging_app/tests/test_messaging.py (+0/-1)
To merge this branch: bzr merge lp:~tiagosh/messaging-app/fix-1227356
Reviewer Review Type Date Requested Status
Gustavo Pichorim Boiko (community) 2013-09-23 Approve on 2013-09-25
PS Jenkins bot continuous-integration Approve on 2013-09-24
Review via email: mp+187114@code.launchpad.net

Commit Message

Focus phone number entry when composing a new message.

Description of the Change

Focus phone number entry when composing a new message.

To post a comment you must log in.
Gustavo Pichorim Boiko (boiko) wrote :

Can you please add an autopilot testcase for this change?

review: Needs Fixing
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
37. By Tiago Salem Herrmann on 2013-09-24

do not click anymore. the field will be focused automatically from now one.

PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Gustavo Pichorim Boiko (boiko) wrote :

Looks good and works as expected!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/qml/Messages.qml'
2--- src/qml/Messages.qml 2013-09-23 22:25:31 +0000
3+++ src/qml/Messages.qml 2013-09-24 18:23:41 +0000
4@@ -181,6 +181,7 @@
5 clip: true
6 height: (number === "" && threadId == "") ? units.gu(7) : 0
7 focus: true
8+ Component.onCompleted: number === "" && newPhoneNumberField.forceActiveFocus()
9
10 Label {
11 id: labelTo
12
13=== modified file 'tests/autopilot/messaging_app/tests/test_messaging.py'
14--- tests/autopilot/messaging_app/tests/test_messaging.py 2013-09-04 16:57:04 +0000
15+++ tests/autopilot/messaging_app/tests/test_messaging.py 2013-09-24 18:23:41 +0000
16@@ -33,7 +33,6 @@
17 self.assertThat(self.main_view.get_pagestack().depth, Eventually(Equals(2)))
18 self.assertThat(self.main_view.get_messages_page().visible, Eventually(Equals(True)))
19 text_entry = self.main_view.get_newmessage_textfield()
20- self.pointing_device.click_object(text_entry)
21 text_entry.activeFocus.wait_for(True)
22 self.keyboard.type("123")
23 self.assertThat(text_entry.text, Eventually(Equals("123")))

Subscribers

People subscribed via source and target branches